Corrections to mlmmj-1.2.2

Corrections to mlmmj-1.2.2

[Uffe Jakobsen]

Hi,

Using Fedore Core 2 and the new mlmmj-1.2.2 I've tried to follow your README in order to establish the mlmmj-test list (for evaluation pusposes)

I've found the following corrections to your README document and sources:

"/etc/aliases": in order to support arguments to the proc alias the command needs to be enclosed in quotes like this:

mlmmj-test:     |"/usr/local/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test/"


Somewhere along the road /usr/local/bin/mlmmj-recieve or some other binary called by mlmmj-recieve logs this message:
log_oper.c:71: Could not open /var/spool/mlmmj/mlmmj-testmlmmj.operation.log: Permission denied

I found out that the problem var related to a missing (final) '/' in the arguments to mlmmj-recieve.

This will provoke the error: /usr/local/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test

Introducing a last '/' will fix the error: /usr/local/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test/

I guess that you've forgot to postpend a '/' between the listdir and the file name for the logfile.


Suggestion the README document does not mention anything about how to build the mlmmj-project.
Maybe it was an idea just to mention that in order to build/install mlmmj the user have to run "./configure" followed by "make" and "make install"... ?

Anyway mlmmj have passed the first hours of my evaluation - it looks as a very promising alternativ to ezmlm/ezmlm-idx !!! :-)

Kind regards Uffe Jakobsen

Re: Corrections to mlmmj-1.2.2

[Mads Martin Joergensen]

* Uffe Jakobsen <uffe@uffe.org> [Feb 03. 2005 15:30]:
> 
> Hi,
> 
> Using Fedore Core 2 and the new mlmmj-1.2.2 I've tried to follow your 
> README in order to establish the mlmmj-test list (for evaluation pusposes)
> 
> I've found the following corrections to your README document and sources:
> 
> "/etc/aliases": in order to support arguments to the proc alias the command 
> needs to be enclosed in quotes like this:
> 
> mlmmj-test:     |"/usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test/"

I think I had it like that once, but someone claimed it should be
otherwise. Is this mailserver dependant?

> Somewhere along the road /usr/local/bin/mlmmj-recieve or some other binary 
> called by mlmmj-recieve logs this message:
> log_oper.c:71: Could not open 
> /var/spool/mlmmj/mlmmj-testmlmmj.operation.log: Permission denied
> 
> I found out that the problem var related to a missing (final) '/' in the 
> arguments to mlmmj-recieve.
> 
> This will provoke the error: /usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test
> 
> Introducing a last '/' will fix the error: /usr/local/bin/mlmmj-recieve -L 
> /var/spool/mlmmj/mlmmj-test/
> 
> I guess that you've forgot to postpend a '/' between the listdir and the 
> file name for the logfile.

Good spotting! Here's a patch to fix it:

--- src/log_oper.c
+++ src/log_oper.c
@@ -49,7 +49,7 @@
        va_list ap;
        size_t i;
 
-       logfilename = concatstr(2, prefix, basename);
+       logfilename = concatstr(3, prefix, "/", basename);
        statres = lstat(logfilename, &st);
        if(statres < 0 && errno != ENOENT) {
                log_error(LOG_ARGS, "Could not stat logfile %s", logfilename);


> Suggestion the README document does not mention anything about how to build 
> the mlmmj-project.
> Maybe it was an idea just to mention that in order to build/install mlmmj 
> the user have to run "./configure" followed by "make" and "make install"... 
> ?

Yeah, you're right. Will do.

> Anyway mlmmj have passed the first hours of my evaluation - it looks as a 
> very promising alternativ to ezmlm/ezmlm-idx !!! :-)

Glad you like it!

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: Corrections to mlmmj-1.2.2

[Uffe Jakobsen]

Hi Martin,

Thanks for your fast response !

Mads Martin Joergensen wrote:
> * Uffe Jakobsen <uffe@uffe.org> [Feb 03. 2005 15:30]:
>>"/etc/aliases": in order to support arguments to the proc alias the command 
>>needs to be enclosed in quotes like this:
>>
>>mlmmj-test:     |"/usr/local/bin/mlmmj-recieve -L 
>>/var/spool/mlmmj/mlmmj-test/"
> 
> 
> I think I had it like that once, but someone claimed it should be
> otherwise. Is this mailserver dependant?
> 
> 

Currently you have this variation (see below) in your README file - that for sure will not work - because '|' needs to be the first non-whitespace char after ':' in /etc/aliases

WRONG:
mlmmj-test:     "|/usr/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test"

RIGHT:
mlmmj-test:     |"/usr/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test"

>>
>>I guess that you've forgot to postpend a '/' between the listdir and the 
>>file name for the logfile.
> 
> 
> Good spotting! Here's a patch to fix it:
> 

I can verify that the fix in src/log_oper.c works for me - thanks !!!  :-)

Kind regards Uffe Jakobsen

Re: Corrections to mlmmj-1.2.2

[Mads Martin Joergensen]

* Uffe Jakobsen <uffe@uffe.org> [Feb 03. 2005 16:26]:
> WRONG:
> mlmmj-test:     "|/usr/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test"
> 
> RIGHT:
> mlmmj-test:     |"/usr/bin/mlmmj-recieve -L /var/spool/mlmmj/mlmmj-test"

I know of Postfix, Sendmail and Exim working with the first syntax
specified here.

What do you base the assumption that it's wrong on?

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.

Re: Corrections to mlmmj-1.2.2

[Uffe Jakobsen]

Hi Martin,

Mads Martin Joergensen wrote:
> 
> I know of Postfix, Sendmail and Exim working with the first syntax
> specified here.
> 
> What do you base the assumption that it's wrong on?
> 

Sorry my mistake just testeted the /etc/aliases "thing" and I found out that I had some kind of "invisible" control/escape char in the string -  sorry about that.

The current description in your README is working fine.

I was blinded by my invisible "bug"-char and due to the fact that man pages on both FC2 and Solaris that '|' should be the first char - only the HPUX man page specifies that "|/som/binary" is legal for aliases file.

Kind regards Uffe Jakobsen

Re: Corrections to mlmmj-1.2.2

[Mads Martin Joergensen]

* Uffe Jakobsen <uffe@uffe.org> [Feb 03. 2005 17:59]:
> Sorry my mistake just testeted the /etc/aliases "thing" and I found out 
> that I had some kind of "invisible" control/escape char in the string -  
> sorry about that.
> 
> The current description in your README is working fine.
> 
> I was blinded by my invisible "bug"-char and due to the fact that man pages 
> on both FC2 and Solaris that '|' should be the first char - only the HPUX 
> man page specifies that "|/som/binary" is legal for aliases file.

Ah, no worries. It was just really puzzling.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.