* Re: [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup
2005-02-10 21:34 [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup Stephen Biggs
@ 2005-02-10 22:15 ` Greg KH
2005-02-11 0:32 ` Stephen Biggs
2005-02-11 0:47 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2005-02-10 22:15 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Thu, Feb 10, 2005 at 11:34:28PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body
> Description: add MODULE definition compile fence so MODULE_DEVICE_TABLE
> vars not declared when compiled into the kernel
>
> Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
>
> diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h
> --- linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h 2005-02-03 03:56:10.000000000 +0200
> +++ linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h 2005-02-07 21:19:25.000000000 +0200
> @@ -139,6 +139,7 @@ static struct usb_midi_device usb_midi_d
>
> #define VENDOR_SPECIFIC_USB_MIDI_DEVICES (sizeof(usb_midi_devices)/sizeof(struct usb_midi_device))
>
> +#ifdef MODULE
> /* for Hot-Plugging */
>
> static struct usb_device_id usb_midi_ids [] = {
> @@ -157,6 +158,7 @@ static struct usb_device_id usb_midi_ids
> };
>
> MODULE_DEVICE_TABLE (usb, usb_midi_ids);
> +#endif /* MODULE */
No, these types of "fixes" have been rejected many times in the past,
and will be rejected again... It's just not worth it.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup
2005-02-10 21:34 [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup Stephen Biggs
2005-02-10 22:15 ` Greg KH
@ 2005-02-11 0:32 ` Stephen Biggs
2005-02-11 0:47 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Biggs @ 2005-02-11 0:32 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 1938 bytes --]
On 10 Feb 2005 at 14:15, Greg KH wrote:
> On Thu, Feb 10, 2005 at 11:34:28PM +0200, Stephen Biggs wrote:
> Content-Description: Mail message body
> > Description: add MODULE definition compile fence so MODULE_DEVICE_TABLE
> > vars not declared when compiled into the kernel
> >
> > Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
> >
> > diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h
> > --- linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h 2005-02-03 03:56:10.000000000 +0200
> > +++ linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h 2005-02-07 21:19:25.000000000 +0200
> > @@ -139,6 +139,7 @@ static struct usb_midi_device usb_midi_d
> >
> > #define VENDOR_SPECIFIC_USB_MIDI_DEVICES (sizeof(usb_midi_devices)/sizeof(struct usb_midi_device))
> >
> > +#ifdef MODULE
> > /* for Hot-Plugging */
> >
> > static struct usb_device_id usb_midi_ids [] = {
> > @@ -157,6 +158,7 @@ static struct usb_device_id usb_midi_ids
> > };
> >
> > MODULE_DEVICE_TABLE (usb, usb_midi_ids);
> > +#endif /* MODULE */
>
> No, these types of "fixes" have been rejected many times in the past,
> and will be rejected again... It's just not worth it.
Ok, I'm in this to learn... can you provide a link to some discussion
where this is talked about in the context of a rejected patch? What is a
better solution to this? I thought this was the cleanest way to do this.
Why is this a "fix" to you (in quotation marks)? If the driver is
compiled as a module, then this table is used, but if it is compiled into
the kernel, it doesn't need the table... this is more of a module
interface design issue in the kernel than it is about a fix that takes
care of the problem.
Please advise, or if you don't want to rehash something, please point me
to some sort of discussion somewhere else, if you can.
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup
2005-02-10 21:34 [KJ] [PATCH][17/26] drivers/usb/class/* - compile warning cleanup Stephen Biggs
2005-02-10 22:15 ` Greg KH
2005-02-11 0:32 ` Stephen Biggs
@ 2005-02-11 0:47 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2005-02-11 0:47 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]
On Fri, Feb 11, 2005 at 02:32:57AM +0200, Stephen Biggs wrote:
> On 10 Feb 2005 at 14:15, Greg KH wrote:
>
> > On Thu, Feb 10, 2005 at 11:34:28PM +0200, Stephen Biggs wrote:
> > Content-Description: Mail message body
> > > Description: add MODULE definition compile fence so MODULE_DEVICE_TABLE
> > > vars not declared when compiled into the kernel
> > >
> > > Signed-off-by: Stephen Biggs <yrgrknmxpzlk@gawab.com>
> > >
> > > diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h
> > > --- linux-2.6.11-rc3-mm-original/drivers/usb/class/usb-midi.h 2005-02-03 03:56:10.000000000 +0200
> > > +++ linux-2.6.11-rc3-mm/drivers/usb/class/usb-midi.h 2005-02-07 21:19:25.000000000 +0200
> > > @@ -139,6 +139,7 @@ static struct usb_midi_device usb_midi_d
> > >
> > > #define VENDOR_SPECIFIC_USB_MIDI_DEVICES (sizeof(usb_midi_devices)/sizeof(struct usb_midi_device))
> > >
> > > +#ifdef MODULE
> > > /* for Hot-Plugging */
> > >
> > > static struct usb_device_id usb_midi_ids [] = {
> > > @@ -157,6 +158,7 @@ static struct usb_device_id usb_midi_ids
> > > };
> > >
> > > MODULE_DEVICE_TABLE (usb, usb_midi_ids);
> > > +#endif /* MODULE */
> >
> > No, these types of "fixes" have been rejected many times in the past,
> > and will be rejected again... It's just not worth it.
>
> Ok, I'm in this to learn... can you provide a link to some discussion
> where this is talked about in the context of a rejected patch? What is a
> better solution to this? I thought this was the cleanest way to do this.
I can't think of the exact link, but this has come up every so often
over the past 4 years on the linux-kernel mailing list.
> Why is this a "fix" to you (in quotation marks)? If the driver is
> compiled as a module, then this table is used, but if it is compiled into
> the kernel, it doesn't need the table... this is more of a module
> interface design issue in the kernel than it is about a fix that takes
> care of the problem.
It's not good to put #ifdefs in .c files. And to do this, just for the
one odd person that does not build with modules enabled, and do it for
every driver in the system, is not a valid idea. A better idea would be
to fix the MODULE_DEVICE_TABLE() macro to be marked __unused__ or
something, so the compiler warning will not happen. That way one fix
solves it for everyone.
good luck,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread