From: Patrick McHardy <kaber@trash.net>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: shemminger@osdl.org, netdev@oss.sgi.com, leo@yuriev.ru
Subject: Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
Date: Sat, 05 Mar 2005 17:08:47 +0100 [thread overview]
Message-ID: <4229D98F.9010008@trash.net> (raw)
In-Reply-To: <20050305141225.GA5180@xi.wantstofly.org>
Lennert Buytenhek wrote:
> ----- Forwarded message from Leo Yuriev <leo@yuriev.ru> -----
>
> From: Leo Yuriev <leo@yuriev.ru>
> To: Lennert Buytenhek <buytenh@gnu.org>,
> Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: linux-kernel@vger.kernel.org
> Subject: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header
>
> Kernel 2.6 (2.6.11)
>
> When ethernet-bridge forward a packet and such ethernet-frame has
> VLAN-tag, bridge should update skb->prioriry for properly QoS
> handling.
>
> This small patch does this. Currently vlan_TCI-priority directly
> mapped to skb->priority, but this looks enough.
>
> Patch-by: Leo Yuriev <leo@yuriev.ru>
It needs to verify the tag is present and accessible using
pskb_may_pull(). But I think an ebtables target similar to the iptables
CLASSIFY target is a better place for this. It could allow setting
skb->priority to an arbitary value or derive it from vlan priority or IP
tos.
Regards
Patrick
next prev parent reply other threads:[~2005-03-05 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 14:12 [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header] Lennert Buytenhek
2005-03-05 16:08 ` Patrick McHardy [this message]
2005-03-05 19:44 ` Ben Greear
2005-03-07 12:48 ` jamal
2005-03-07 19:36 ` Patrick McHardy
2005-03-07 23:35 ` jamal
2005-03-07 23:53 ` Patrick McHardy
2005-03-08 0:19 ` jamal
2005-03-08 3:38 ` Patrick McHardy
2005-03-08 13:13 ` jamal
2005-03-08 17:45 ` Ben Greear
2005-03-08 21:43 ` jamal
2005-03-10 13:26 ` Re[2]: " Leo Yuriev
2005-03-10 14:42 ` jamal
2005-03-07 18:07 ` Stephen Hemminger
2005-03-07 18:13 ` Ben Greear
2005-03-07 18:16 ` Patrick McHardy
2005-03-07 18:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4229D98F.9010008@trash.net \
--to=kaber@trash.net \
--cc=buytenh@wantstofly.org \
--cc=leo@yuriev.ru \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.