From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Ben Greear <greearb@candelatech.com>,
leo@yuriev.ru, Lennert Buytenhek <buytenh@wantstofly.org>,
shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
Date: Tue, 08 Mar 2005 04:38:14 +0100 [thread overview]
Message-ID: <422D1E26.1010902@trash.net> (raw)
In-Reply-To: <1110241190.1043.100.camel@jzny.localdomain>
jamal wrote:
> Indeed that looks bad. But wouldnt have helped if we started at 0
> either. You need monotonically increasing values to make proper
> sense. So i suppose to do proper qos with L2, one must install the prio
> qdisc and rewrite the priomap.
One reason more to move it to an optional ebtables target. Or leave it
all to prio + u32. But I guess a CLASSIFY target similar to iptables
could also be useful otherwise.
> The mapping used in pfifo_fast is derived from RFC1349 4 bit TOS which
> is really considered toast these days. We need to revamp things - but
> this would require some surgery in the route code as well (so maybe safe
> to leave as is).
Are there any changes required besides ip_tos2prio ? More importantly,
it there a different meaningful mapping to priorities we can apply ?
Regards
Patrick
next prev parent reply other threads:[~2005-03-08 3:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 14:12 [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header] Lennert Buytenhek
2005-03-05 16:08 ` Patrick McHardy
2005-03-05 19:44 ` Ben Greear
2005-03-07 12:48 ` jamal
2005-03-07 19:36 ` Patrick McHardy
2005-03-07 23:35 ` jamal
2005-03-07 23:53 ` Patrick McHardy
2005-03-08 0:19 ` jamal
2005-03-08 3:38 ` Patrick McHardy [this message]
2005-03-08 13:13 ` jamal
2005-03-08 17:45 ` Ben Greear
2005-03-08 21:43 ` jamal
2005-03-10 13:26 ` Re[2]: " Leo Yuriev
2005-03-10 14:42 ` jamal
2005-03-07 18:07 ` Stephen Hemminger
2005-03-07 18:13 ` Ben Greear
2005-03-07 18:16 ` Patrick McHardy
2005-03-07 18:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422D1E26.1010902@trash.net \
--to=kaber@trash.net \
--cc=buytenh@wantstofly.org \
--cc=greearb@candelatech.com \
--cc=hadi@cyberus.ca \
--cc=leo@yuriev.ru \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.