From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Ben Greear <greearb@candelatech.com>, netdev@oss.sgi.com
Subject: Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
Date: Mon, 07 Mar 2005 19:16:50 +0100 [thread overview]
Message-ID: <422C9A92.6040902@trash.net> (raw)
In-Reply-To: <20050307100744.429e100a@dxpl.pdx.osdl.net>
Stephen Hemminger wrote:
>>
>>This small patch does this. Currently vlan_TCI-priority directly
>>mapped to skb->priority, but this looks enough.
>
> I don't see why the VLAN code doesn't handle this itself. I don't like special
> case layer violations because it becomes a slippery slope with more and
> more additions.
The patch is meant for bridges briging vlan frames without doing
vlan themselves. I agree with you, from the bridge point of view
a vlan header is just as outside of its scope as an IP header,
that's why I proposed to put it in an ebtables target and make
it useable for vlan and IP.
Regards
Patrick
next prev parent reply other threads:[~2005-03-07 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-05 14:12 [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header] Lennert Buytenhek
2005-03-05 16:08 ` Patrick McHardy
2005-03-05 19:44 ` Ben Greear
2005-03-07 12:48 ` jamal
2005-03-07 19:36 ` Patrick McHardy
2005-03-07 23:35 ` jamal
2005-03-07 23:53 ` Patrick McHardy
2005-03-08 0:19 ` jamal
2005-03-08 3:38 ` Patrick McHardy
2005-03-08 13:13 ` jamal
2005-03-08 17:45 ` Ben Greear
2005-03-08 21:43 ` jamal
2005-03-10 13:26 ` Re[2]: " Leo Yuriev
2005-03-10 14:42 ` jamal
2005-03-07 18:07 ` Stephen Hemminger
2005-03-07 18:13 ` Ben Greear
2005-03-07 18:16 ` Patrick McHardy [this message]
2005-03-07 18:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422C9A92.6040902@trash.net \
--to=kaber@trash.net \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.