All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm
Date: Thu, 17 Nov 2022 11:25:48 +0000	[thread overview]
Message-ID: <423905ec-1584-3035-7c9e-d118296b4d04@intel.com> (raw)
In-Reply-To: <20221013084007.19843-2-nirmoy.das@intel.com>

On 13/10/2022 09:40, Nirmoy Das wrote:
> Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause
> dmesg spamming. Use ratelimit api to reduce log rate.
> 
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>


> ---
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index d63f30efd631..6b60b99461e2 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -1080,8 +1080,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>   		}
>   
>   		if (err) {
> -			drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n",
> -				ERR_PTR(err));
> +			drm_dbg_ratelimited(dev,
> +					    "Unable to make resource CPU accessible(err = %pe)\n",
> +					    ERR_PTR(err));
>   			dma_resv_unlock(bo->base.resv);
>   			ret = VM_FAULT_SIGBUS;
>   			goto out_rpm;

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Auld <matthew.auld@intel.com>
To: Nirmoy Das <nirmoy.das@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm
Date: Thu, 17 Nov 2022 11:25:48 +0000	[thread overview]
Message-ID: <423905ec-1584-3035-7c9e-d118296b4d04@intel.com> (raw)
In-Reply-To: <20221013084007.19843-2-nirmoy.das@intel.com>

On 13/10/2022 09:40, Nirmoy Das wrote:
> Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause
> dmesg spamming. Use ratelimit api to reduce log rate.
> 
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>


> ---
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index d63f30efd631..6b60b99461e2 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -1080,8 +1080,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
>   		}
>   
>   		if (err) {
> -			drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n",
> -				ERR_PTR(err));
> +			drm_dbg_ratelimited(dev,
> +					    "Unable to make resource CPU accessible(err = %pe)\n",
> +					    ERR_PTR(err));
>   			dma_resv_unlock(bo->base.resv);
>   			ret = VM_FAULT_SIGBUS;
>   			goto out_rpm;

  reply	other threads:[~2022-11-17 11:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13  8:40 [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited Nirmoy Das
2022-10-13  8:40 ` Nirmoy Das
2022-10-13  8:40 ` [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm Nirmoy Das
2022-10-13  8:40   ` Nirmoy Das
2022-11-17 11:25   ` Matthew Auld [this message]
2022-11-17 11:25     ` Matthew Auld
2022-10-13  9:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/print: Add drm_dbg_ratelimited Patchwork
2022-10-13  9:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-13 13:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-17 11:43 ` [Intel-gfx] [PATCH 1/2] " Matthew Auld
2022-11-17 11:43   ` Matthew Auld
  -- strict thread matches above, loose matches on Subject: below --
2023-01-17 11:53 Nirmoy Das
2023-01-17 11:53 ` [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm Nirmoy Das
2023-01-17 11:59   ` Andrzej Hajda
2023-01-17 13:56   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=423905ec-1584-3035-7c9e-d118296b4d04@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.