All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@aknet.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: petkov@uni-muenster.de, jamagallon@able.es, linux-kernel@vger.kernel.org
Subject: [patch 2/3]: entry.S trap return fixes
Date: Tue, 12 Apr 2005 23:47:31 +0400	[thread overview]
Message-ID: <425C25D3.7010703@aknet.ru> (raw)
In-Reply-To: <20050411212712.0dbd821d.akpm@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Hello.

do_debug() returns void, do_int3() too when
!CONFIG_KPROBES.
This patch fixes the CONFIG_KPROBES variant
of do_int3() to return void too and adjusts
the entry.S accordingly.

Signed-off-by: Stas Sergeev <stsp@aknet.ru>


[-- Attachment #2: kgdbfix1.diff --]
[-- Type: text/x-patch, Size: 1158 bytes --]

--- linux/arch/i386/kernel/entry.S.old	2005-04-12 09:47:38.000000000 +0400
+++ linux/arch/i386/kernel/entry.S	2005-04-12 11:13:03.000000000 +0400
@@ -550,8 +550,6 @@
 	xorl %edx,%edx			# error code 0
 	movl %esp,%eax			# pt_regs pointer
 	call do_debug
-	testl %eax,%eax
-	jnz restore_all
 	jmp ret_from_exception
 
 /*
@@ -632,8 +630,6 @@
 	xorl %edx,%edx		# zero error code
 	movl %esp,%eax		# pt_regs pointer
 	call do_int3
-	testl %eax,%eax
-	jnz restore_all
 	jmp ret_from_exception
 
 ENTRY(overflow)
--- linux/arch/i386/kernel/traps.c.old	2005-04-12 09:47:38.000000000 +0400
+++ linux/arch/i386/kernel/traps.c	2005-04-12 10:59:54.000000000 +0400
@@ -695,16 +695,15 @@
 }
 
 #ifdef CONFIG_KPROBES
-fastcall int do_int3(struct pt_regs *regs, long error_code)
+fastcall void do_int3(struct pt_regs *regs, long error_code)
 {
 	if (notify_die(DIE_INT3, "int3", regs, error_code, 3, SIGTRAP)
 			== NOTIFY_STOP)
-		return 1;
+		return;
 	/* This is an interrupt gate, because kprobes wants interrupts
 	disabled.  Normal trap handlers don't. */
 	restore_interrupts(regs);
 	do_trap(3, SIGTRAP, "int3", 1, regs, error_code, NULL);
-	return 0;
 }
 #endif
 

  parent reply	other threads:[~2005-04-12 21:02 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-11  8:25 2.6.12-rc2-mm3 Andrew Morton
2005-04-11  8:56 ` 2.6.12-rc2-mm3 J.A. Magallon
2005-04-11  9:43   ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-11 21:59     ` 2.6.12-rc2-mm3 Borislav Petkov
2005-04-11 22:22       ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12  4:20         ` 2.6.12-rc2-mm3 Stas Sergeev
2005-04-12  4:27           ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12 19:37             ` [patch 0/3] 2.6.12-rc2-mm3 Stas Sergeev
2005-04-12 19:42             ` [patch 1/3]: move config option for BAD_SYSCALL_EXIT Stas Sergeev
2005-04-12 19:47             ` Stas Sergeev [this message]
2005-04-13  2:09               ` [patch 2/3]: entry.S trap return fixes Andrew Morton
2005-04-13  3:18                 ` Stas Sergeev
2005-04-12 19:54             ` [patch 3/3]: fix BAD_SYSCALL_EXIT lockup Stas Sergeev
2005-04-12 12:22           ` 2.6.12-rc2-mm3 Borislav Petkov
2005-04-11 10:34 ` 2.6.12-rc2-mm3 Jan Dittmer
2005-04-11 17:33 ` 2.6.12-rc2-mm3 Benoit Boissinot
2005-04-11 19:11 ` 2.6.12-rc2-mm3 Jindrich Makovicka
2005-04-12  0:22   ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12  8:21     ` 2.6.12-rc2-mm3 Jindrich Makovicka
2005-04-11 20:46 ` 2.6.12-rc2-mm3 Martin J. Bligh
2005-04-11 22:24   ` 2.6.12-rc2-mm3 Benoit Boissinot
2005-04-12 22:32     ` 2.6.12-rc2-mm3 Martin J. Bligh
2005-04-11 21:05 ` 2.6.12-rc2-mm3: CONFIG_MODULES=n MTD compile error Adrian Bunk
2005-04-11 21:07   ` Adrian Bunk
2005-04-12  1:18 ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-12  2:09   ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-12  3:26   ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-12  4:42     ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-12  6:34       ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-12 18:08         ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-12 22:40           ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-13  1:44             ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-15 18:23   ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-15 23:23     ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-17  8:40       ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-24  0:01         ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-24  1:59           ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-24  2:15             ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-04-24  3:14               ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-24  4:25               ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-24  9:53               ` 2.6.12-rc2-mm3 Oleg Nesterov
2005-04-24 23:11                 ` 2.6.12-rc2-mm3 Juergen Kreileder
2005-04-25  0:09                   ` 2.6.12-rc2-mm3 Benjamin Herrenschmidt
2005-05-03  6:29                 ` 2.6.12-rc2-mm3 Andrew Morton
2005-05-03 10:42                   ` 2.6.12-rc2-mm3 Oleg Nesterov
2005-04-12  5:00 ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12  5:51   ` 2.6.12-rc2-mm3 Nick Piggin
2005-04-12  6:19     ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12  6:49       ` 2.6.12-rc2-mm3 Nick Piggin
2005-04-12  7:50         ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-12 19:03           ` 2.6.12-rc2-mm3 Steven Pratt
2005-04-12 17:01       ` 2.6.12-rc2-mm3 Steven Pratt
2005-04-12  7:06   ` 2.6.12-rc2-mm3 Jens Axboe
2005-04-12 11:32 ` 2.6.12-rc2-mm3 Ed Tomlinson
2005-04-12 11:39   ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-14  0:15     ` 2.6.12-rc2-mm3 Ed Tomlinson
2005-04-14  0:20       ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-14  0:38         ` 2.6.12-rc2-mm3 Ed Tomlinson
2005-04-14  0:54           ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-17 21:32 ` [-mm patch] fix "make mandocs" Adrian Bunk
2005-04-17 22:27 ` 2.6.12-rc2-mm3 Alexander Nyberg
2005-04-17 22:36 ` 2.6.12-rc2-mm3 Alexander Nyberg
2005-04-19  2:03 ` 2.6.12-rc2-mm3: hostap: do not #include .c files Adrian Bunk
2005-04-19  2:12   ` Jouni Malinen
2005-04-19  2:12     ` Jouni Malinen
2005-04-26  0:49 ` 2.6.12-rc2-mm3 Randy.Dunlap
2005-04-26  1:06   ` 2.6.12-rc2-mm3 Andrew Morton
2005-04-26  3:17   ` 2.6.12-rc2-mm3 Greg KH
2005-04-26 16:15     ` 2.6.12-rc2-mm3 Randy.Dunlap
2005-04-27 10:41 ` 2.6.12-rc2-mm3 Alexander Nyberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=425C25D3.7010703@aknet.ru \
    --to=stsp@aknet.ru \
    --cc=akpm@osdl.org \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkov@uni-muenster.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.