All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	haveblue@us.ibm.com, kravetz@us.ibm.com
Subject: Re: [3/3] sparsemem memory model for ppc64
Date: Thu, 05 May 2005 18:37:00 +0100	[thread overview]
Message-ID: <427A59BC.1020208@shadowen.org> (raw)
In-Reply-To: <20050505023132.GB20283@austin.ibm.com>

Olof Johansson wrote:
> Hi,
> 
> Just two formatting nitpicks below.

Thanks, this would be better served by rewriting the first comment and
removing the second all together.

/* Add all physical memory to the bootmem map, mark each area
 * present.  The first block has already been marked present above.
 */

I note that the diff in question has sneaked into the wrong patch, that
segement represents memory_present.  So I'll rediff them with it there.
 No overall change to the code.

-apw

WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc64-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	haveblue@us.ibm.com, kravetz@us.ibm.com
Subject: Re: [3/3] sparsemem memory model for ppc64
Date: Thu, 05 May 2005 18:37:00 +0100	[thread overview]
Message-ID: <427A59BC.1020208@shadowen.org> (raw)
In-Reply-To: <20050505023132.GB20283@austin.ibm.com>

Olof Johansson wrote:
> Hi,
> 
> Just two formatting nitpicks below.

Thanks, this would be better served by rewriting the first comment and
removing the second all together.

/* Add all physical memory to the bootmem map, mark each area
 * present.  The first block has already been marked present above.
 */

I note that the diff in question has sneaked into the wrong patch, that
segement represents memory_present.  So I'll rediff them with it there.
 No overall change to the code.

-apw
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2005-05-05 17:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-04 20:30 [3/3] sparsemem memory model for ppc64 Andy Whitcroft
2005-05-04 20:30 ` Andy Whitcroft
2005-05-05  2:31 ` Olof Johansson
2005-05-05  2:31   ` Olof Johansson
2005-05-05 17:37   ` Andy Whitcroft [this message]
2005-05-05 17:37     ` Andy Whitcroft
2005-05-09 15:49     ` sparsemem ppc64 tidy flat memory comments and fix benign mempresent call Andy Whitcroft
2005-05-09 15:49       ` Andy Whitcroft
2005-05-09 23:03       ` Joel Schopp
2005-05-09 23:03         ` Joel Schopp
2005-05-10 15:45         ` Andy Whitcroft
2005-05-10 19:42           ` mike kravetz
2005-05-10 19:42             ` mike kravetz
2005-05-17 13:08           ` [PATCH] sparsemem-ppc64-flat-first-block-is-not-special Andy Whitcroft
2005-05-17 13:08             ` Andy Whitcroft
2005-05-05 17:53 ` [3/3] sparsemem memory model for ppc64 mike kravetz
2005-05-05 17:53   ` mike kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427A59BC.1020208@shadowen.org \
    --to=apw@shadowen.org \
    --cc=anton@samba.org \
    --cc=haveblue@us.ibm.com \
    --cc=kravetz@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.