Assertion failure on shadow.c:2339 for VMX domains

Assertion failure on shadow.c:2339 for VMX domains

[Arun Sharma]

Hi Michael,

This assertion you added:

005/05/09 mafetter   |             ASSERT(VM_ASSIST(d, 
VMASST_TYPE_writable_pagetables));

is failing for VMX domains. Why do you think this assertion belongs there?

	-Arun

Full log:

(XEN) DOM1P0: FSH_LOG(77): shadow_promote: gpfn=4df gmfn=3fb54 nt=40000000
(XEN) DOM1P0: SH_LOG(1462): Allocate more shadow hashtable blocks.
(XEN) DOM1P0: FSH_LOG(77): shadow_promote: gpfn=529 gmfn=3fb0a nt=20000000
(XEN) DOM1P0: FSH_LOG(77): shadow_promote: gpfn=52a gmfn=3fb09 nt=20000000
(XEN) DOM1P0: SH_LOG(668): Free shadow table.
(XEN) DOM1P0: FSH_LOG(77): shadow_promote: gpfn=4df gmfn=3fb54 nt=40000000
(XEN) DOM1P0: FSH_LOG(77): shadow_promote: gpfn=52a gmfn=3fb09 nt=20000000
(XEN) DOM1P0: FSH_LOG(1704): Allocate more fullshadow tuple blocks.
(XEN) DOM1P0: FSH_LOG(1833): shadow_mark_mfn_out_of_sync(gpfn=52a, 
mfn=3fb09) c0
(XEN) DOM1P0: FSH_LOG(1897): mark_out_of_sync(va=c052a000 -> 
writable_pl1e=6c0e)
(XEN) DOM1P0: FSH_LOG(2317): resyncing t=20000000 gpfn=52a gmfn=3fb09 
smfn=6c0ed
(XEN) Assertion 'VM_ASSIST(d, VMASST_TYPE_writable_pagetables)' failed, 
line 23c

Re: Assertion failure on shadow.c:2339 for VMX domains

[Arun Sharma]

Arun Sharma wrote:
> Hi Michael,
> 
> This assertion you added:
> 
> 005/05/09 mafetter   |             ASSERT(VM_ASSIST(d, 
> VMASST_TYPE_writable_pagetables));
> 
> is failing for VMX domains. Why do you think this assertion belongs there?

Ditto for the other two below as well.

	-Arun

--- 1.111/xen/arch/x86/shadow.c 2005-05-12 06:58:45 -07:00
+++ edited/arch/x86/shadow.c    2005-05-13 15:49:11 -07:00
@@ -2336,8 +2336,6 @@
              l1_pgentry_t *shadow1 = shadow;
              l1_pgentry_t *snapshot1 = snapshot;

-            ASSERT(VM_ASSIST(d, VMASST_TYPE_writable_pagetables));
-
              if ( !shadow_mode_refcounts(d) )
                  revalidate_l1(d, guest1, snapshot1);

@@ -2383,7 +2381,6 @@
              l2_pgentry_t *shadow2 = shadow;
              l2_pgentry_t *snapshot2 = snapshot;

-            ASSERT(shadow_mode_write_all(d));
              BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

              changed = 0;
@@ -2426,7 +2423,6 @@
              l2_pgentry_t *snapshot2 = snapshot;
              l1_pgentry_t *shadow2 = shadow;

-            ASSERT(shadow_mode_write_all(d));
              BUG_ON(!shadow_mode_refcounts(d)); // not yet implemented

              changed = 0;


>