Minor note FYI

["Artem B. Bityuckiy" <dedekind@yandex.ru>]

Hello,

Look at the create_child_common() function at fs/reiser4/plugin/dir/dir.c:

There are _7_ places with the code like this in it:

result = blah();
if (result) {
	warning();
         DQUOT_FREE_INODE(object);
         object->i_flags |= S_NOQUOTA;
         return result;
}

isn't it cuter to use the classical way:

result = blah();
if (result) {
	warning();
	goto error;
}

...

error:
         DQUOT_FREE_INODE(object);
         object->i_flags |= S_NOQUOTA;
         return result;

?

-- 
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.