[PATCH] reiserfs: reformat code with Lindent

[PATCH] reiserfs: reformat code with Lindent

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey all -

Just out of curiousity, does anyone outside of Chris and I have
outstanding patches against ReiserFS? I ask because the tree has been
relatively stable for some time and I wonder if it may be time to submit
a Lindent patch to clean up the code and reformat it to adhere to the
kernel style guidelines.

I've posted a patch[1] that is only the output of the Lindent script.
Ideally, there should be some string formatting in there as well, but
I'd like to split them up into separate pieces so we know each chunk is
correct. Sorry I couldn't attach it - it was rejected by the list since
it is over 128k in size.

Opinions?

- -Jeff
[1]:
ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCzYzFLPWxlyuTD7IRAgrZAJ0YpbRkSz7XoGKOyal62s1qTGdw/wCcCNQx
aFRMUp8q8+cRQ6XluvE5zgg=
=ZYGV
-----END PGP SIGNATURE-----

Re: [PATCH] reiserfs: reformat code with Lindent

[Hans Reiser]

Jeff Mahoney wrote:

> Hey all -
>
> Just out of curiousity, does anyone outside of Chris and I have
> outstanding patches against ReiserFS? I ask because the tree has been
> relatively stable for some time and I wonder if it may be time to submit
> a Lindent patch to clean up the code and reformat it to adhere to the
> kernel style guidelines.
>
> I've posted a patch[1] that is only the output of the Lindent script.
> Ideally, there should be some string formatting in there as well, but
> I'd like to split them up into separate pieces so we know each chunk is
> correct. Sorry I couldn't attach it - it was rejected by the list since
> it is over 128k in size.
>
> Opinions?
>
> -Jeff
> [1]:
> ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff
>
> --
> Jeff Mahoney
> SuSE Labs


I don't have any enthusiasm or desire for changing the indentation, but
I will not fight it to the death.

Re: [PATCH] reiserfs: reformat code with Lindent

[Vladimir V. Saveliev]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hello

Jeff Mahoney wrote:
> Hey all -
> 
> Just out of curiousity, does anyone outside of Chris and I have
> outstanding patches against ReiserFS? 

I have no idea how the attached patch managed to not get included.

I ask because the tree has been
> relatively stable for some time and I wonder if it may be time to submit
> a Lindent patch to clean up the code and reformat it to adhere to the
> kernel style guidelines.
> 
> I've posted a patch[1] that is only the output of the Lindent script.
> Ideally, there should be some string formatting in there as well, but
> I'd like to split them up into separate pieces so we know each chunk is
> correct. Sorry I couldn't attach it - it was rejected by the list since
> it is over 128k in size.
> 
> Opinions?
> 
> -Jeff
> [1]:
> ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/cleanups/2.6.13-rc2/01-reiserfs-lindent.diff
> 
> --
> Jeff Mahoney
> SuSE Labs

[-- Attachment #2: reiserfs-old-read-bitmap.patch --]
[-- Type: text/plain, Size: 1031 bytes --]

 fs/reiserfs/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN fs/reiserfs/super.c~reiserfs-old-read-bitmap fs/reiserfs/super.c
--- linux-2.6.12/fs/reiserfs/super.c~reiserfs-old-read-bitmap	2005-07-08 00:51:07.171918740 +0400
+++ linux-2.6.12-vs/fs/reiserfs/super.c	2005-07-08 00:51:54.185318407 +0400
@@ -1286,11 +1286,11 @@ static int read_old_bitmaps (struct supe
   int bmp1 = (REISERFS_OLD_DISK_OFFSET_IN_BYTES / s->s_blocksize) + 1;  /* first of bitmap blocks */
 
   /* read true bitmap */
-  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  SB_AP_BITMAP (s) = vmalloc (sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
   if (SB_AP_BITMAP (s) == 0)
     return 1;
 
-  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_buffer_info *) * sb_bmap_nr(rs));
+  memset (SB_AP_BITMAP (s), 0, sizeof (struct reiserfs_bitmap_info) * sb_bmap_nr(rs));
 
   for (i = 0; i < sb_bmap_nr(rs); i ++) {
     SB_AP_BITMAP (s)[i].bh = sb_bread (s, bmp1 + i);

_

Re: [PATCH] reiserfs: reformat code with Lindent

[Jeff Mahoney]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vladimir V. Saveliev wrote:
> Hello
> 
> Jeff Mahoney wrote:
>> Hey all -
>>
>> Just out of curiousity, does anyone outside of Chris and I have
>> outstanding patches against ReiserFS? 
> 
> I have no idea how the attached patch managed to not get included.

Interesting. I guess that pretty much tells us how many people are using
old format disks on somewhat recent kernels. :)

Have you resubmitted?

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCzZogLPWxlyuTD7IRAteZAJsH/wsTSnsUrublVKUQny/rgadelACfd5iK
hxltGLICaSwEX+rfxzAEkCM=
=sstn
-----END PGP SIGNATURE-----

Re: [PATCH] reiserfs: reformat code with Lindent

[Vladimir V. Saveliev]

Hello

Jeff Mahoney wrote:
> Vladimir V. Saveliev wrote:
> 
>>>Hello
>>>
>>>Jeff Mahoney wrote:
>>>
>>>>Hey all -
>>>>
>>>>Just out of curiousity, does anyone outside of Chris and I have
>>>>outstanding patches against ReiserFS? 
>>>
>>>I have no idea how the attached patch managed to not get included.
> 
> 
> Interesting. I guess that pretty much tells us how many people are using
> old format disks on somewhat recent kernels. :)
> 
yes, but less then one month ago we had a bug report: user could not mount because of this problem.

> Have you resubmitted?

no
> 
> -Jeff
> 
> --
> Jeff Mahoney
> SuSE Labs