All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Bug-fixing and keystroke
@ 2005-08-01 10:11 Serbinenko Vladimir
  2005-08-01 10:58 ` Marco Gerards
  0 siblings, 1 reply; 5+ messages in thread
From: Serbinenko Vladimir @ 2005-08-01 10:11 UTC (permalink / raw)
  To: The development of GRUB 2

>On Saturday 30 July 2005 15:20, Serbinenko Vladimir wrote:
>>/ I wrote some bugfixing patch + new feature./
>
>Thank you very much. I have applied only the bugfixes at the moment.
>

OK

>>/ The new feature is sending keystroke to OS (imitating keypress +/
>>/ changing keyboard flags)./
>>/ it works like:/
>>/     keystroke [flags] [keys]/
>
>This is specific to i386-pc, so the source file should be put in 
>commands/i386/pc.

Fixed

>I'm also wondering if this command name is good or not. In QEMU, the same 
>feature is called "sendkey". I'm not sure which is better.

For me it makes no difference but if other apps use "sendkey" it would be better make standardly

>Another question I have is that it might be better to implement this as a 
>variable rather than a command. Basically, this command just stores 
>information rathen than executing something directly. So using a variable 
>sounds intuitive for me.
>
>What do you think?
>

I propose one "sendkey" variable and bunch of kb_* variables like kb_caps, kb_scroll, kb_rshift, kb_noleds ... 
Is it OK?
Then 2 questions arise:
1) Which values would be intuitive for kb_*?What about keep, on, off?
2) How can user call the help? Especially how can user know the available keys? Perhaps this question is more
 general and we have to extend "help" command?

>Okuji
>
									Vladimir Serbinenko




^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: Bug-fixing and keystroke
@ 2005-08-02 12:16 Vladimir Serbinenko
  0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Serbinenko @ 2005-08-02 12:16 UTC (permalink / raw)
  To: The development of GRUB 2

>
>
>Serbinenko Vladimir <address@hidden> writes:
>
>>/ 2) How can user call the help? Especially how can user know the/
>>/ available keys? Perhaps this question is more general and we have to/
>>/ extend "help" command?/
>
>How about something like `sendkeys --list-keys'.  Does that make
>sense?
>
>  
>

The problem is that sendkey is a variable. So we have no command.
I could also write a command but does it make sense to have command and
a variable?
The same problem we have with pager and root variables but while root is
set form the
beginning and quite intuitive, pager is intuitive but at the beginning
you don't see it so you
have to know that it exists but sendkey and kb_* are not very intuitive
and set only when
you load sendkey module.
                                                                        
            Vladimir

P. S. I've just written the "hide", "unhide" and "parttype" commands.
Will send a patch after testing




^ permalink raw reply	[flat|nested] 5+ messages in thread
* netboot and memory problem : solved ?
@ 2005-06-17 23:52 Vincent Guffens
  2005-06-18 13:51 ` Ext2fs support bug Serbinenko Vladimir
  0 siblings, 1 reply; 5+ messages in thread
From: Vincent Guffens @ 2005-06-17 23:52 UTC (permalink / raw)
  To: The development of GRUB 2

hi !


what do you think about the following change in grub_free ?

Instead of (at the end of the function)

   if (p + p->size == p->next)
   {
     p->next->magic = 0;
     p->size += p->next->size;
     p->next = p->next->next;
   }
[...]
r->first = q;


I tried the following


   if (p + p->size == p->next)
   {
     p->next->magic = 0;
     p->size += p->next->size;
     p->next = p->next->next;
     r->first = p;
     return;
   }


as a reminder, my problem was that sometimes, grub2 would fataly print 
(error message from grub_free):

free magic is broken at 0x37e50: 0x0

I'm quite sure that my problem is linked with that region of the code, 
but I'm not too sure about the consequences of that possible fix.

At least, I can't repoduce the problem on my pc but I'll do some more 
testing on monday as this problem is kind of "volatile".

I hope it's the one ! Have a good week-end !

-- 
				Vincent Guffens
				PhD Student UCL/CESAME
				tel:   +32 10 47 80 30
Value your freedom, or you will lose it, teaches history.
"Don't bother us with politics," respond those who don't want to learn.
	      	-- Richard M. Stallman



^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-08-02 12:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-01 10:11 Bug-fixing and keystroke Serbinenko Vladimir
2005-08-01 10:58 ` Marco Gerards
  -- strict thread matches above, loose matches on Subject: below --
2005-08-02 12:16 Vladimir Serbinenko
2005-06-17 23:52 netboot and memory problem : solved ? Vincent Guffens
2005-06-18 13:51 ` Ext2fs support bug Serbinenko Vladimir
2005-07-13 16:42   ` Marco Gerards
2005-07-30 13:20     ` Bug-fixing and keystroke Serbinenko Vladimir
2005-07-31 16:19       ` Yoshinori K. Okuji

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.