From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Harald Welte <laforge@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] Drop expectation refcount after unlinking expectation
Date: Fri, 05 Aug 2005 12:21:00 +0200 [thread overview]
Message-ID: <42F33D8C.5070904@trash.net> (raw)
In-Reply-To: <42F2B507.8070207@eurodev.net>
Pablo Neira wrote:
> This patch comes from the following thread:
>
> [PATCH 6/7] Fix expectation creation
>
> In unlink_expect, the expectation is removed from the list so the
> refcount must be dropped as well.
The patch is fine, but it leaves the somewhat broken function
__ip_ct_expect_unlink_destroy around. I'm not sure what the
intention of this function is, it looks like a lazy way of
killing conntracks without manually dropping the timer refcnt.
Anyway it invites people to use it in the wrong place and
should die IMO.
next prev parent reply other threads:[~2005-08-05 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 0:38 [PATCH] Drop expectation refcount after unlinking expectation Pablo Neira
2005-08-05 10:21 ` Patrick McHardy [this message]
2005-08-05 13:17 ` Harald Welte
2005-08-06 14:29 ` Patrick McHardy
2005-08-05 10:43 ` Patrick McHardy
2005-08-05 13:08 ` Harald Welte
2005-08-06 14:24 ` Patrick McHardy
2005-08-08 0:59 ` Yasuyuki KOZAKAI
2005-08-05 13:20 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F33D8C.5070904@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.