From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Pablo Neira <pablo@eurodev.net>
Subject: Re: [PATCH] Drop expectation refcount after unlinking expectation
Date: Sat, 06 Aug 2005 16:24:32 +0200 [thread overview]
Message-ID: <42F4C820.7020209@trash.net> (raw)
In-Reply-To: <20050805130803.GI4245@rama.de.gnumonks.org>
Harald Welte wrote:
> On Fri, Aug 05, 2005 at 12:43:04PM +0200, Patrick McHardy wrote:
>
>>Pablo Neira wrote:
>>
>>>OK, my question is: why do we need to increase the master conntrack
>>>refcount for expectations, if they are always killed first? Actually I
>>>think that the master conntrack refcount should be increased once the
>>>expectation is confirmed but not in ip_conntrack_expect_alloc.
>>
>>Only outstanding expectations are removed by remove_expectations().
>>The fullfilled ones need the reference for stuff like
>>ip_nat_follow_master.
>
> So Pablo's argument stil upholds... in theory it would be sufficient to
> increase the master refcount when expectation is fulfilled(confirmed)
> instead of allocation time. Or am I missing something?
No, it is possible, but we do take a reference in expect_alloc, and I
don't see the point of obscuring the reference counting by increasing
the count at a later point in time.
next prev parent reply other threads:[~2005-08-06 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 0:38 [PATCH] Drop expectation refcount after unlinking expectation Pablo Neira
2005-08-05 10:21 ` Patrick McHardy
2005-08-05 13:17 ` Harald Welte
2005-08-06 14:29 ` Patrick McHardy
2005-08-05 10:43 ` Patrick McHardy
2005-08-05 13:08 ` Harald Welte
2005-08-06 14:24 ` Patrick McHardy [this message]
2005-08-08 0:59 ` Yasuyuki KOZAKAI
2005-08-05 13:20 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F4C820.7020209@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.