[PATCH] Fix TypeError when starting VMX domains

[PATCH] Fix TypeError when starting VMX domains

[Arun Sharma]

The attached patch fixes this traceback:

Traceback (most recent call last):
   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 510, in construct
     self.construct_image()
   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 574, in 
construct_image
     self.store_channel)
   File "/usr/lib/python/xen/xend/xenstore/xsobj.py", line 310, in 
introduceDomain
     log.info("DBMap>introduceDomain> %d %d %s %s" %(dom, page, evtchn, 
path))
TypeError: int argument required

--- a/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 20:22:16 2005
+++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 15:00:19 2005
@@ -239,7 +239,7 @@

          self.channel = None
          self.store_channel = None
-        self.store_mfn = None
+        self.store_mfn = 0
          self.controllers = {}

Re: [PATCH] Fix TypeError when starting VMX domains

[Christian Limpach]

On 8/8/05, Arun Sharma <arun.sharma@intel.com> wrote:
> 
> The attached patch fixes this traceback:

When does this happen?  It seems that the fix will only hide the real
cause of the failure and I'd rather fix the underlying bug.  It's odd
that we have initialized the store_channel but not figured out what
the store_mfn is.

    christian

> Traceback (most recent call last):
>   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 510, in construct
>     self.construct_image()
>   File "/usr/lib/python/xen/xend/XendDomainInfo.py", line 574, in
> construct_image
>     self.store_channel)
>   File "/usr/lib/python/xen/xend/xenstore/xsobj.py", line 310, in
> introduceDomain
>     log.info("DBMap>introduceDomain> %d %d %s %s" %(dom, page, evtchn,
> path))
> TypeError: int argument required
> 
> --- a/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 20:22:16 2005
> +++ b/tools/python/xen/xend/XendDomainInfo.py   Mon Aug  8 15:00:19 2005
> @@ -239,7 +239,7 @@
> 
>          self.channel = None
>          self.store_channel = None
> -        self.store_mfn = None
> +        self.store_mfn = 0
>          self.controllers = {}
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>

Re: [PATCH] Fix TypeError when starting VMX domains

[Arun Sharma]

Christian Limpach wrote:
> On 8/8/05, Arun Sharma <arun.sharma@intel.com> wrote:
> 
>>The attached patch fixes this traceback:
> 
> 
> When does this happen?  It seems that the fix will only hide the real
> cause of the failure and I'd rather fix the underlying bug.  It's odd
> that we have initialized the store_channel but not figured out what
> the store_mfn is.

The real issue is that xc_vmx_build.c was not kept upto date with the 
xenstore changes. Working on it now.

	-Arun

Re: [PATCH] Fix TypeError when starting VMX domains

[Arun Sharma]

Arun Sharma wrote:
> Christian Limpach wrote:
> 
>> On 8/8/05, Arun Sharma <arun.sharma@intel.com> wrote:
>>
>>> The attached patch fixes this traceback:
>>
>>
>>
>> When does this happen?  It seems that the fix will only hide the real
>> cause of the failure and I'd rather fix the underlying bug.  It's odd
>> that we have initialized the store_channel but not figured out what
>> the store_mfn is.
> 
> 
> The real issue is that xc_vmx_build.c was not kept upto date with the 
> xenstore changes. Working on it now.
> 

It's resolved by this changeset.

http://xenbits.xensource.com/ext/xen-vt-testing.hg?cmd=changeset;node=02121365cfff9cfa8e57cc37a560df5305360b58

	-Arun

Re: [PATCH] Fix TypeError when starting VMX domains

[Christian Limpach]

On Tue, Aug 09, 2005 at 04:42:09PM -0700, Arun Sharma wrote:
> Arun Sharma wrote:
> >Christian Limpach wrote:
> >
> >>On 8/8/05, Arun Sharma <arun.sharma@intel.com> wrote:
> >>
> >>>The attached patch fixes this traceback:
> >>
> >>
> >>
> >>When does this happen?  It seems that the fix will only hide the real
> >>cause of the failure and I'd rather fix the underlying bug.  It's odd
> >>that we have initialized the store_channel but not figured out what
> >>the store_mfn is.
> >
> >
> >The real issue is that xc_vmx_build.c was not kept upto date with the 
> >xenstore changes. Working on it now.
> >
> 
> It's resolved by this changeset.
> 
> http://xenbits.xensource.com/ext/xen-vt-testing.hg?cmd=changeset;node=02121365cfff9cfa8e57cc37a560df5305360b58

I've applied this.  Thanks!

    christian