All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers inherits
@ 2005-09-30 16:52 Laurent Riffard
  2005-10-01 21:49 ` [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers Jean Delvare
  2005-10-01 23:07 ` Laurent Riffard
  0 siblings, 2 replies; 3+ messages in thread
From: Laurent Riffard @ 2005-09-30 16:52 UTC (permalink / raw)
  To: lm-sensors

In function i2c_isa_add_driver, copied driver should inherit the owner field
as well as the name field.


Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
---

Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
=================================--- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c      2005-09-30 16:27:50.000000000 +0200
+++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c   2005-09-30 16:34:00.903153000 +0200
@@ -92,6 +92,7 @@

        /* Add the driver to the list of i2c drivers in the driver core */
        driver->driver.name = driver->name;
+       driver->driver.owner = driver->owner;
        driver->driver.bus = &i2c_bus_type;
        driver->driver.probe = i2c_isa_device_probe;
        driver->driver.remove = i2c_isa_device_remove;



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050930/d6b71bde/signature.bin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers
  2005-09-30 16:52 [lm-sensors] [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers inherits Laurent Riffard
@ 2005-10-01 21:49 ` Jean Delvare
  2005-10-01 23:07 ` Laurent Riffard
  1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2005-10-01 21:49 UTC (permalink / raw)
  To: lm-sensors

Hi Laurent,

> In function i2c_isa_add_driver, copied driver should inherit the owner field
> as well as the name field.
> 
> 
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
> ---
> 
> Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
> =================================> --- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c      2005-09-30 16:27:50.000000000 +0200
> +++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c   2005-09-30 16:34:00.903153000 +0200
> @@ -92,6 +92,7 @@
> 
>         /* Add the driver to the list of i2c drivers in the driver core */
>         driver->driver.name = driver->name;
> +       driver->driver.owner = driver->owner;
>         driver->driver.bus = &i2c_bus_type;
>         driver->driver.probe = i2c_isa_device_probe;
>         driver->driver.remove = i2c_isa_device_remove;
> 
> 

This one doesn't apply, because of tabs/spaces conversions it seems.
Please resend in a suitable form.

BTW, I appreciate diffstat output in the patch headers, it helps
figuring out at a glance which files a patch affects and how.

Thanks,
-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers
  2005-09-30 16:52 [lm-sensors] [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers inherits Laurent Riffard
  2005-10-01 21:49 ` [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers Jean Delvare
@ 2005-10-01 23:07 ` Laurent Riffard
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Riffard @ 2005-10-01 23:07 UTC (permalink / raw)
  To: lm-sensors


Le 01.10.2005 21:49, Jean Delvare a ?crit :
> Hi Laurent,
> 
>>In function i2c_isa_add_driver, copied driver should inherit the owner field
>>as well as the name field.
>>
>>
>>Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
>>---
>>
[snip]
> 
> This one doesn't apply, because of tabs/spaces conversions it seems.
> Please resend in a suitable form.
> 
> BTW, I appreciate diffstat output in the patch headers, it helps
> figuring out at a glance which files a patch affects and how.
> 
> Thanks,

Oops ! Sorry about that... here is an updated version:

---
In function i2c_isa_add_driver, copied driver should inherit the owner field
as well as the name field.

Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
---

 i2c-isa.c |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
=================================--- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c	2005-09-09 23:39:50.000000000 +0200
+++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c	2005-09-10 10:55:14.425721250 +0200
@@ -92,6 +92,7 @@
 
 	/* Add the driver to the list of i2c drivers in the driver core */
 	driver->driver.name = driver->name;
+	driver->driver.owner = driver->owner;
 	driver->driver.bus = &i2c_bus_type;
 	driver->driver.probe = i2c_isa_device_probe;
 	driver->driver.remove = i2c_isa_device_remove;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20051001/55d9e139/signature.bin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-10-01 23:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-30 16:52 [lm-sensors] [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers inherits Laurent Riffard
2005-10-01 21:49 ` [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers Jean Delvare
2005-10-01 23:07 ` Laurent Riffard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.