Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

slackfan@users.sourceforge.net (slackfan@users.sourceforge.net) wrote:
> signed-off-by: Anton Brondz
> 
> --- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
> +++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 12:36:30.000000000 +0000
> @@ -23,23 +23,23 @@ static void doublefault_fn(void)
>  	store_gdt(&gdt_desc);
>  	gdt = gdt_desc.address;
>  
> -	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> +	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> [...]
>}
>  	}
> 
> 
> This is the third time I'm sending this. Hope you're not tired of me yet :). This time I've added a signed off line, used a different mail client to get the word
> wrap off and changed the constants.

Please use correctly Signed-off-by such as :

	Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

Send your patch with correct syntax as said in :

	http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Have a nice day,

				- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

slackfan@users.sourceforge.net (slackfan@users.sourceforge.net) wrote:
> signed-off-by: Anton Brondz
> 
> --- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
> +++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 12:36:30.000000000 +0000
> @@ -23,23 +23,23 @@ static void doublefault_fn(void)
>  	store_gdt(&gdt_desc);
>  	gdt = gdt_desc.address;
>  
> -	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> +	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);

When a double fault happens we are not in good terms with os ;)
So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags.
I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.

Please read it (Debugging by printing : printk):

	http://lwn.net/images/pdf/LDD3/ch04.pdf

Have a nice day,

			- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] arch/i386/kernel/doublefault.c

[slackfan]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

signed-off-by: Anton Brondz

--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 12:36:30.000000000 +0000
@@ -23,23 +23,23 @@ static void doublefault_fn(void)
 	store_gdt(&gdt_desc);
 	gdt = gdt_desc.address;
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
 
 	if (ptr_ok(gdt)) {
 		gdt += GDT_ENTRY_TSS << 3;
 		tss = *(u16 *)(gdt+2);
 		tss += *(u8 *)(gdt+4) << 16;
 		tss += *(u8 *)(gdt+7) << 24;
-		printk("double fault, tss at %08lx\n", tss);
+		printk(KERN_NOTICE "double fault, tss at %08lx\n", tss);
 
 		if (ptr_ok(tss)) {
 			struct tss_struct *t = (struct tss_struct *)tss;
 
-			printk("eip = %08lx, esp = %08lx\n", t->eip, t->esp);
+			printk(KERN_NOTICE "eip = %08lx, esp = %08lx\n", t->eip, t->esp);
 
-			printk("eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
+			printk(KERN_NOTICE "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
 				t->eax, t->ebx, t->ecx, t->edx);
-			printk("esi = %08lx, edi = %08lx\n",
+			printk(KERN_ERR "esi = %08lx, edi = %08lx\n",
 				t->esi, t->edi);
 		}
 	}


This is the third time I'm sending this. Hope you're not tired of me yet :). This time I've added a signed off line, used a different mail client to get the word
wrap off and changed the constants.

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

Dinolinux (anton.slack@tele2.no) wrote:
> Christophe Lucas wrote:
> 
> >slackfan@users.sourceforge.net (slackfan@users.sourceforge.net) wrote:
> >  
> >
> >>signed-off-by: Anton Brondz
> >>
> >>--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
> >>+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 12:36:30.000000000 +0000
> >>@@ -23,23 +23,23 @@ static void doublefault_fn(void)
> >> 	store_gdt(&gdt_desc);
> >> 	gdt = gdt_desc.address;
> >> 
> >>-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> >>+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> >>    
> >>
> >
> >When a double fault happens we are not in good terms with os ;)
> >So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags.
> >I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.
> >
> >Please read it (Debugging by printing : printk):
> >
> >	http://lwn.net/images/pdf/LDD3/ch04.pdf
> >
> >Have a nice day,
>
> Now I've made some editing on the patch. I don't want to send the whole
> thing now as there may be some more editing. I'll put only the lines
> with the constants here now.
> 
> *printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt,
> gdt_desc.size);*
> KERN_ALERT because it prints the address of the double fault which
> requires immediate action.
> 
> *printk(KERN_CRIT "double fault, tss at %08lx\n", tss);*
> KERN_CRIT because it prints the tss address.
> *
> printk(KERN_CRIT "eip = %08lx, esp = %08lx\n", t->eip, t->esp);
> *KERN_CRIT because it prints eip and esp address.
> 
> *printk(KERN_CRIT "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
>                 t->eax, t->ebx, t->ecx, t->edx);
> *KERN_CRIT because it prints eax, ebx, ecx and edx address.
> 
> *printk(KERN_CRIT "esi = %08lx, edi = %08lx\n",
>                 t->esi, t->edi);
> *KERN_CRIT because it prints esi and edi address.
> 
> Hope this is better, so I can send the patch. ;-)

I think it will be better.

				- Christophe (clucas@rotomalug.org)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Dinolinux]

[-- Attachment #1.1: Type: text/plain, Size: 2159 bytes --]

Christophe Lucas wrote:

>slackfan@users.sourceforge.net (slackfan@users.sourceforge.net) wrote:
>  
>
>>signed-off-by: Anton Brondz
>>
>>--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
>>+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 12:36:30.000000000 +0000
>>@@ -23,23 +23,23 @@ static void doublefault_fn(void)
>> 	store_gdt(&gdt_desc);
>> 	gdt = gdt_desc.address;
>> 
>>-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
>>+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
>>    
>>
>
>When a double fault happens we are not in good terms with os ;)
>So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags.
>I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.
>
>Please read it (Debugging by printing : printk):
>
>	http://lwn.net/images/pdf/LDD3/ch04.pdf
>
>Have a nice day,
>
>			- Christophe (clucas@rotomalug.org)
>
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Kernel-janitors mailing list
>Kernel-janitors@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/kernel-janitors
>  
>
Now I've made some editing on the patch. I don't want to send the whole
thing now as there may be some more editing. I'll put only the lines
with the constants here now.

*printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt,
gdt_desc.size);*
KERN_ALERT because it prints the address of the double fault which
requires immediate action.

*printk(KERN_CRIT "double fault, tss at %08lx\n", tss);*
KERN_CRIT because it prints the tss address.
*
printk(KERN_CRIT "eip = %08lx, esp = %08lx\n", t->eip, t->esp);
*KERN_CRIT because it prints eip and esp address.

*printk(KERN_CRIT "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
                t->eax, t->ebx, t->ecx, t->edx);
*KERN_CRIT because it prints eax, ebx, ecx and edx address.

*printk(KERN_CRIT "esi = %08lx, edi = %08lx\n",
                t->esi, t->edi);
*KERN_CRIT because it prints esi and edi address.

Hope this is better, so I can send the patch. ;-)

[-- Attachment #1.2: Type: text/html, Size: 3332 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [PATCH] arch/i386/kernel/doublefault.c

[slackfan]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

signed-off-by: Anton Brondz <anton.slack@tele2.no>

--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c	2005-09-20 03:00:41.000000000 +0000
+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c	2005-10-03 14:37:44.000000000 +0000
@@ -23,23 +23,23 @@ static void doublefault_fn(void)
 	store_gdt(&gdt_desc);
 	gdt = gdt_desc.address;
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
 
 	if (ptr_ok(gdt)) {
 		gdt += GDT_ENTRY_TSS << 3;
 		tss = *(u16 *)(gdt+2);
 		tss += *(u8 *)(gdt+4) << 16;
 		tss += *(u8 *)(gdt+7) << 24;
-		printk("double fault, tss at %08lx\n", tss);
+		printk(KERN_CRIT "double fault, tss at %08lx\n", tss);
 
 		if (ptr_ok(tss)) {
 			struct tss_struct *t = (struct tss_struct *)tss;
 
-			printk("eip = %08lx, esp = %08lx\n", t->eip, t->esp);
+			printk(KERN_CRIT "eip = %08lx, esp = %08lx\n", t->eip, t->esp);
 
-			printk("eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
+			printk(KERN_CRIT "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
 				t->eax, t->ebx, t->ecx, t->edx);
-			printk("esi = %08lx, edi = %08lx\n",
+			printk(KERN_CRIT "esi = %08lx, edi = %08lx\n",
 				t->esi, t->edi);
 		}
 	}

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

On Mon, Oct 03, 2005 at 04:54:41PM +0000, slackfan@users.sourceforge.net wrote:
> --- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c
> +++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c

> -	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> +	printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
>
>  	if (ptr_ok(gdt)) {
>  		gdt += GDT_ENTRY_TSS << 3;
>  		tss = *(u16 *)(gdt+2);
>  		tss += *(u8 *)(gdt+4) << 16;
>  		tss += *(u8 *)(gdt+7) << 24;
> -		printk("double fault, tss at %08lx\n", tss);
> +		printk(KERN_CRIT "double fault, tss at %08lx\n", tss);

Different priorities?


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c

[Dinolinux]

Alexey Dobriyan wrote:

>On Mon, Oct 03, 2005 at 04:54:41PM +0000, slackfan@users.sourceforge.net wrote:
>  
>
>>--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c
>>+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c
>>    
>>
>
>  
>
>>-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
>>+	printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
>>
>> 	if (ptr_ok(gdt)) {
>> 		gdt += GDT_ENTRY_TSS << 3;
>> 		tss = *(u16 *)(gdt+2);
>> 		tss += *(u8 *)(gdt+4) << 16;
>> 		tss += *(u8 *)(gdt+7) << 24;
>>-		printk("double fault, tss at %08lx\n", tss);
>>+		printk(KERN_CRIT "double fault, tss at %08lx\n", tss);
>>    
>>
>
>Different priorities?
>
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Kernel-janitors mailing list
>Kernel-janitors@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/kernel-janitors
>  
>
Will it be better if I put KERN_CRIT on all printk lines?

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors