[PATCH] fbdev: fix the fb_find_nearest_mode() function

[PATCH] fbdev: fix the fb_find_nearest_mode() function

[Michal Januszewski]

[-- Attachment #1: Type: text/plain, Size: 3897 bytes --]

Currently the fb_find_nearest_mode() function finds a mode with
screen resolution closest to that described by the 'var' argument
and with some arbitrary refresh rate (eg. in the following sequence
of refresh rates: 70 60 53 85 75, 53 is selected).

This patch fixes the function so that it looks for the closest mode as 
far as both resolution and refresh rate are concerned. The function's
first argument is changed to fb_videomode so that the refresh rate can
be specified by the caller, as fb_var_screeninfo doesn't have any fields
that could directly hold this data.

Signed-off-by: Michal Januszewski <spock@gentoo.org>
---

diff -Nurp fbdev-orig/drivers/video/console/fbcon.c fbdev/drivers/video/console/fbcon.c
--- fbdev-orig/drivers/video/console/fbcon.c	2005-10-08 23:14:29.000000000 +0200
+++ fbdev/drivers/video/console/fbcon.c	2005-10-09 01:03:22.000000000 +0200
@@ -2758,7 +2758,7 @@ static void fbcon_new_modelist(struct fb
 			continue;
 		vc = vc_cons[i].d;
 		display_to_var(&var, &fb_display[i]);
-		mode = fb_find_nearest_mode(&var, &info->modelist);
+		mode = fb_find_nearest_mode(fb_display[i].mode, &info->modelist);
 		fb_videomode_to_var(&var, mode);
 
 		if (vc)
diff -Nurp fbdev-orig/drivers/video/modedb.c fbdev/drivers/video/modedb.c
--- fbdev-orig/drivers/video/modedb.c	2005-10-08 23:14:29.000000000 +0200
+++ fbdev/drivers/video/modedb.c	2005-10-09 01:25:16.000000000 +0200
@@ -663,6 +663,7 @@ void fb_var_to_videomode(struct fb_video
 {
 	u32 pixclock, hfreq, htotal, vtotal;
 
+	mode->refresh = 0;
 	mode->name = NULL;
 	mode->xres = var->xres;
 	mode->yres = var->yres;
@@ -785,39 +786,39 @@ struct fb_videomode *fb_find_best_mode(s
 }
 
 /**
- * fb_find_nearest_mode - find mode closest video mode
+ * fb_find_nearest_mode - find closest videomode
  *
- * @var: pointer to struct fb_var_screeninfo
+ * @mode: pointer to struct fb_videomode
  * @head: pointer to modelist
  *
  * Finds best matching videomode, smaller or greater in dimension.
  * If more than 1 videomode is found, will return the videomode with
- * the closest refresh rate
+ * the closest refresh rate.
  */
-struct fb_videomode *fb_find_nearest_mode(struct fb_var_screeninfo *var,
+struct fb_videomode *fb_find_nearest_mode(struct fb_videomode *mode,
 					  struct list_head *head)
 {
 	struct list_head *pos;
 	struct fb_modelist *modelist;
-	struct fb_videomode *mode, *best = NULL;
+	struct fb_videomode *cmode, *best = NULL;
 	u32 diff = -1, diff_refresh = -1;
 
 	list_for_each(pos, head) {
 		u32 d;
 
 		modelist = list_entry(pos, struct fb_modelist, list);
-		mode = &modelist->mode;
+		cmode = &modelist->mode;
 
-		d = abs(mode->xres - var->xres) +
-			abs(mode->yres - var->yres);
+		d = abs(cmode->xres - mode->xres) +
+			abs(cmode->yres - mode->yres);
 		if (diff > d) {
 			diff = d;
-			best = mode;
+			best = cmode;
 		} else if (diff == d) {
-			d = abs(mode->refresh - best->refresh);
+			d = abs(cmode->refresh - mode->refresh);
 			if (diff_refresh > d) {
 				diff_refresh = d;
-				best = mode;
+				best = cmode;
 			}
 		}
 	}
diff -Nurp fbdev-orig/include/linux/fb.h fbdev/include/linux/fb.h
--- fbdev-orig/include/linux/fb.h	2005-10-08 23:14:40.000000000 +0200
+++ fbdev/include/linux/fb.h	2005-10-09 01:03:17.000000000 +0200
@@ -898,7 +898,7 @@ extern struct fb_videomode *fb_match_mod
 					  struct list_head *head);
 extern struct fb_videomode *fb_find_best_mode(struct fb_var_screeninfo *var,
 					      struct list_head *head);
-extern struct fb_videomode *fb_find_nearest_mode(struct fb_var_screeninfo *var,
+extern struct fb_videomode *fb_find_nearest_mode(struct fb_videomode *mode,
 						 struct list_head *head);
 extern void fb_destroy_modelist(struct list_head *head);
 extern void fb_videomode_to_modelist(struct fb_videomode *modedb, int num,


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fbdev: fix the fb_find_nearest_mode() function

[Antonino A. Daplas]

Michal Januszewski wrote:
> Currently the fb_find_nearest_mode() function finds a mode with
> screen resolution closest to that described by the 'var' argument
> and with some arbitrary refresh rate (eg. in the following sequence
> of refresh rates: 70 60 53 85 75, 53 is selected).
> 
> This patch fixes the function so that it looks for the closest mode as 
> far as both resolution and refresh rate are concerned. The function's
> first argument is changed to fb_videomode so that the refresh rate can
> be specified by the caller, as fb_var_screeninfo doesn't have any fields
> that could directly hold this data.
> 

I like it. I always wanted to fix this but I keep on forgetting :-)

> Signed-off-by: Michal Januszewski <spock@gentoo.org>
> ---
> 
> diff -Nurp fbdev-orig/drivers/video/console/fbcon.c fbdev/drivers/video/console/fbcon.c
> --- fbdev-orig/drivers/video/console/fbcon.c	2005-10-08 23:14:29.000000000 +0200
> +++ fbdev/drivers/video/console/fbcon.c	2005-10-09 01:03:22.000000000 +0200
> @@ -2758,7 +2758,7 @@ static void fbcon_new_modelist(struct fb
>  			continue;
>  		vc = vc_cons[i].d;
>  		display_to_var(&var, &fb_display[i]);
> -		mode = fb_find_nearest_mode(&var, &info->modelist);
> +		mode = fb_find_nearest_mode(fb_display[i].mode, &info->modelist);
>  		fb_videomode_to_var(&var, mode);
>  
>  		if (vc)
> diff -Nurp fbdev-orig/drivers/video/modedb.c fbdev/drivers/video/modedb.c
> --- fbdev-orig/drivers/video/modedb.c	2005-10-08 23:14:29.000000000 +0200
> +++ fbdev/drivers/video/modedb.c	2005-10-09 01:25:16.000000000 +0200
> @@ -663,6 +663,7 @@ void fb_var_to_videomode(struct fb_video
>  {
>  	u32 pixclock, hfreq, htotal, vtotal;
>  
> +	mode->refresh = 0;

Any reason why you need to set mode->refresh to 0?

Tony


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] fbdev: fix the fb_find_nearest_mode() function

[Michal Januszewski]

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Mon, Oct 10, 2005 at 04:21:51PM +0800, Antonino A. Daplas wrote:

> > diff -Nurp fbdev-orig/drivers/video/modedb.c fbdev/drivers/video/modedb.c
> > --- fbdev-orig/drivers/video/modedb.c	2005-10-08 23:14:29.000000000 +0200
> > +++ fbdev/drivers/video/modedb.c	2005-10-09 01:25:16.000000000 +0200
> > @@ -663,6 +663,7 @@ void fb_var_to_videomode(struct fb_video
> >  {
> >  	u32 pixclock, hfreq, htotal, vtotal;
> >  
> > +	mode->refresh = 0;
> 
> Any reason why you need to set mode->refresh to 0?

This is something I had to use in a driver I'm currently working on and
I thought it might be a good idea to include it in the patch I sent.

The thing is, if the var struct has the pixclock field set to 0,
mode->refresh is left untouched, which could mean that it's either
set to a random value or to an invalid refresh rate coming from a
previously processed videomode (in case the fb_videomode struct is
reused).

I actually dealt with modes with var->pixclock == 0, and it always resulted
in a getting U:<xres>x<yres>-<random> in /sys/class/graphics/fb0/modes.

In case you're wondering why would anyone ever need to have
var->pixclock set to 0 -- I was using it to denote modes with a default
refresh rate set by the hardware (well, the Video BIOS to be more
specific). Please let me know is this is very wrong, but I just didn't
see any other way of doing it.

-- 
Michal Januszewski                                Gentoo Linux Developer
cell: +48504917690                         http://dev.gentoo.org/~spock/
JID: spock@im.gentoo.org               freenode: #gentoo-dev, #gentoo-pl


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fbdev: fix the fb_find_nearest_mode() function

[Antonino A. Daplas]

Michal Januszewski wrote:
> On Mon, Oct 10, 2005 at 04:21:51PM +0800, Antonino A. Daplas wrote:
> 
>>> diff -Nurp fbdev-orig/drivers/video/modedb.c fbdev/drivers/video/modedb.c
>>> --- fbdev-orig/drivers/video/modedb.c	2005-10-08 23:14:29.000000000 +0200
>>> +++ fbdev/drivers/video/modedb.c	2005-10-09 01:25:16.000000000 +0200
>>> @@ -663,6 +663,7 @@ void fb_var_to_videomode(struct fb_video
>>>  {
>>>  	u32 pixclock, hfreq, htotal, vtotal;
>>>  
>>> +	mode->refresh = 0;
>> Any reason why you need to set mode->refresh to 0?
> 
> This is something I had to use in a driver I'm currently working on and
> I thought it might be a good idea to include it in the patch I sent.
> 
> The thing is, if the var struct has the pixclock field set to 0,
> mode->refresh is left untouched, which could mean that it's either
> set to a random value or to an invalid refresh rate coming from a
> previously processed videomode (in case the fb_videomode struct is
> reused).

Ok.

> 
> I actually dealt with modes with var->pixclock == 0, and it always resulted
> in a getting U:<xres>x<yres>-<random> in /sys/class/graphics/fb0/modes.
> 
> In case you're wondering why would anyone ever need to have
> var->pixclock set to 0 -- I was using it to denote modes with a default
> refresh rate set by the hardware (well, the Video BIOS to be more
> specific). Please let me know is this is very wrong, but I just didn't
> see any other way of doing it.

No, it's not wrong. But it is preferrable to have a nonzero value in
var->pixclock (whether calculated or via a VBE function call).

Still, I agree with you to initialize mode->refresh to zero (or perhaps
-1 to to denote a divide by zero) for these cases.

Tony
 



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

Re: [PATCH] fbdev: fix the fb_find_nearest_mode() function

[Michal Januszewski]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

On Fri, Oct 14, 2005 at 08:18:08AM +0800, Antonino A. Daplas wrote:

> > In case you're wondering why would anyone ever need to have
> > var->pixclock set to 0 -- I was using it to denote modes with a default
> > refresh rate set by the hardware (well, the Video BIOS to be more
> > specific). Please let me know is this is very wrong, but I just didn't
> > see any other way of doing it.
> 
> No, it's not wrong. But it is preferrable to have a nonzero value in
> var->pixclock (whether calculated or via a VBE function call).
> 
> Still, I agree with you to initialize mode->refresh to zero (or perhaps
> -1 to to denote a divide by zero) for these cases.

OK, nice. I'd say that 0 might be a little cleaner (we're avoiding
<nn>x<nn>-4294967295 entries in the sysfs nodes without having to
write any additional code). Also, no one should be dividing anything by
mode->refresh without checking its contents first, so having a zero
there doesn't seem like something dangerous. But, ultimately it's
up to you to decide, of course.

-- 
Michal Januszewski                                Gentoo Linux Developer
cell: +48504917690                         http://dev.gentoo.org/~spock/
JID: spock@im.gentoo.org               freenode: #gentoo-dev, #gentoo-pl


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]