From: Arnd Bergmann <arnd@arndb.de>
To: Georgi Djakov <gdjakov@mm-sol.com>
Cc: linux@arm.linux.org.uk, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, sboyd@codeaurora.org,
rvaswani@codeaurora.org, davidb@codeaurora.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 4/4] ARM: debug: qcom: Add APQ8084 DEBUG_LL UART support
Date: Wed, 21 May 2014 17:18:52 +0200 [thread overview]
Message-ID: <4365639.JcFl1cP048@wuerfel> (raw)
In-Reply-To: <1400684225-21381-5-git-send-email-gdjakov@mm-sol.com>
On Wednesday 21 May 2014 17:57:05 Georgi Djakov wrote:
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index eab8ecb..91d5184 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -101,6 +101,15 @@ choice
> bool "Kernel low-level debugging on 9263 and 9g45"
> depends on HAVE_AT91_DBGU1
>
> + config DEBUG_APQ8084_UART
> + bool "Kernel low-level debugging messages via APQ8084 UART"
> + depends on ARCH_QCOM
> + select MSM_HAS_DEBUG_UART_HS
> + select DEBUG_MSM_UART
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to the serial port on Qualcomm APQ8084 devices.
> +
> config DEBUG_BCM2835
> bool "Kernel low-level debugging on BCM2835 PL011 UART"
> depends on ARCH_BCM2835
> diff --git a/arch/arm/include/debug/msm.S b/arch/arm/include/debug/msm.S
> index 9d653d4..178636d 100644
> --- a/arch/arm/include/debug/msm.S
> +++ b/arch/arm/include/debug/msm.S
> @@ -36,6 +36,11 @@
> #define MSM_DEBUG_UART_PHYS MSM_UART3_PHYS
> #endif
>
> +#ifdef CONFIG_DEBUG_APQ8084_UART
> +#define MSM_DEBUG_UART_BASE 0xFA75E000
> +#define MSM_DEBUG_UART_PHYS 0xF995E000
> +#endif
> +
> #ifdef CONFIG_DEBUG_MSM8660_UART
> #define MSM_DEBUG_UART_BASE 0xF0040000
> #define MSM_DEBUG_UART_PHYS 0x19C40000
>
Maybe we should move debug/msm.S over to use
CONFIG_DEBUG_UART_PHYS/CONFIG_DEBUG_UART_VIRT now?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 4/4] ARM: debug: qcom: Add APQ8084 DEBUG_LL UART support
Date: Wed, 21 May 2014 17:18:52 +0200 [thread overview]
Message-ID: <4365639.JcFl1cP048@wuerfel> (raw)
In-Reply-To: <1400684225-21381-5-git-send-email-gdjakov@mm-sol.com>
On Wednesday 21 May 2014 17:57:05 Georgi Djakov wrote:
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index eab8ecb..91d5184 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -101,6 +101,15 @@ choice
> bool "Kernel low-level debugging on 9263 and 9g45"
> depends on HAVE_AT91_DBGU1
>
> + config DEBUG_APQ8084_UART
> + bool "Kernel low-level debugging messages via APQ8084 UART"
> + depends on ARCH_QCOM
> + select MSM_HAS_DEBUG_UART_HS
> + select DEBUG_MSM_UART
> + help
> + Say Y here if you want the debug print routines to direct
> + their output to the serial port on Qualcomm APQ8084 devices.
> +
> config DEBUG_BCM2835
> bool "Kernel low-level debugging on BCM2835 PL011 UART"
> depends on ARCH_BCM2835
> diff --git a/arch/arm/include/debug/msm.S b/arch/arm/include/debug/msm.S
> index 9d653d4..178636d 100644
> --- a/arch/arm/include/debug/msm.S
> +++ b/arch/arm/include/debug/msm.S
> @@ -36,6 +36,11 @@
> #define MSM_DEBUG_UART_PHYS MSM_UART3_PHYS
> #endif
>
> +#ifdef CONFIG_DEBUG_APQ8084_UART
> +#define MSM_DEBUG_UART_BASE 0xFA75E000
> +#define MSM_DEBUG_UART_PHYS 0xF995E000
> +#endif
> +
> #ifdef CONFIG_DEBUG_MSM8660_UART
> #define MSM_DEBUG_UART_BASE 0xF0040000
> #define MSM_DEBUG_UART_PHYS 0x19C40000
>
Maybe we should move debug/msm.S over to use
CONFIG_DEBUG_UART_PHYS/CONFIG_DEBUG_UART_VIRT now?
Arnd
next prev parent reply other threads:[~2014-05-21 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 14:57 [PATCH v1 0/4] Add Qualcomm APQ8084 SoC support Georgi Djakov
2014-05-21 14:57 ` Georgi Djakov
2014-05-21 14:57 ` [PATCH v1 1/4] ARM: dts: qcom: Add " Georgi Djakov
2014-05-21 14:57 ` Georgi Djakov
2014-05-21 17:24 ` Stephen Boyd
2014-05-21 17:24 ` Stephen Boyd
2014-05-21 20:16 ` Georgi Djakov
2014-05-21 20:16 ` Georgi Djakov
2014-05-21 14:57 ` [PATCH v1 2/4] ARM: dts: qcom: Add APQ8084-MTP board support Georgi Djakov
2014-05-21 14:57 ` Georgi Djakov
2014-05-21 14:57 ` [PATCH v1 3/4] ARM: qcom: Add APQ8084-MTP board to mach-qcom Georgi Djakov
2014-05-21 14:57 ` Georgi Djakov
2014-05-21 15:18 ` Kumar Gala
2014-05-21 15:18 ` Kumar Gala
2014-05-21 15:39 ` Georgi Djakov
2014-05-21 15:39 ` Georgi Djakov
2014-05-21 14:57 ` [PATCH v1 4/4] ARM: debug: qcom: Add APQ8084 DEBUG_LL UART support Georgi Djakov
2014-05-21 14:57 ` Georgi Djakov
2014-05-21 15:18 ` Arnd Bergmann [this message]
2014-05-21 15:18 ` Arnd Bergmann
2014-05-21 15:28 ` Ivan T. Ivanov
2014-05-21 15:28 ` Ivan T. Ivanov
2014-05-21 19:14 ` Kumar Gala
2014-05-21 19:14 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4365639.JcFl1cP048@wuerfel \
--to=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gdjakov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rvaswani@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.