All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gabriel A. Devenyi" <ace@staticwave.ca>
To: davej@codemonkey.org.uk
Cc: cpufreq@lists.linux.org.uk, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
Date: Tue, 08 Nov 2005 07:38:35 -0500	[thread overview]
Message-ID: <43709C4B.5010607@staticwave.ca> (raw)

Thanks to LinuxICC (http://linuxicc.sf.net), a comparison of a u32 less than 0 was found, this patch changes the variable to a signed int so that comparison is meaningful.

This patch applies to linus' git tree as of 02.11.2005

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

--
diff --git a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 04a4053..039297b 100644
--- a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -177,9 +177,9 @@ static unsigned int nforce2_fsb_read(int
   */
  static int nforce2_set_fsb(unsigned int fsb)
  {
-	u32 pll, temp = 0;
+	u32 temp = 0;
  	unsigned int tfsb;
-	int diff;
+	int diff, pll = 0;

  	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
  		printk(KERN_ERR "cpufreq: FSB %d is out of range!\n", fsb);


-- 
Gabriel A. Devenyi
ace@staticwave.ca

WARNING: multiple messages have this Message-ID (diff)
From: "Gabriel A. Devenyi" <ace@staticwave.ca>
To: davej@codemonkey.org.uk
Cc: cpufreq@lists.linux.org.uk, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [KJ] [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
Date: Tue, 08 Nov 2005 12:38:35 +0000	[thread overview]
Message-ID: <43709C4B.5010607@staticwave.ca> (raw)

Thanks to LinuxICC (http://linuxicc.sf.net), a comparison of a u32 less than 0 was found, this patch changes the variable to a signed int so that comparison is meaningful.

This patch applies to linus' git tree as of 02.11.2005

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

--
diff --git a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 04a4053..039297b 100644
--- a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -177,9 +177,9 @@ static unsigned int nforce2_fsb_read(int
   */
  static int nforce2_set_fsb(unsigned int fsb)
  {
-	u32 pll, temp = 0;
+	u32 temp = 0;
  	unsigned int tfsb;
-	int diff;
+	int diff, pll = 0;

  	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
  		printk(KERN_ERR "cpufreq: FSB %d is out of range!\n", fsb);


-- 
Gabriel A. Devenyi
ace@staticwave.ca
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2005-11-08 12:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 12:38 Gabriel A. Devenyi [this message]
2005-11-08 12:38 ` [KJ] [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c Gabriel A. Devenyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43709C4B.5010607@staticwave.ca \
    --to=ace@staticwave.ca \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@codemonkey.org.uk \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.