All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@ 2005-11-08 12:38 ` Gabriel A. Devenyi
  0 siblings, 0 replies; 2+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-08 12:38 UTC (permalink / raw)
  To: davej; +Cc: cpufreq, linux-kernel, kernel-janitors

Thanks to LinuxICC (http://linuxicc.sf.net), a comparison of a u32 less than 0 was found, this patch changes the variable to a signed int so that comparison is meaningful.

This patch applies to linus' git tree as of 02.11.2005

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

--
diff --git a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 04a4053..039297b 100644
--- a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -177,9 +177,9 @@ static unsigned int nforce2_fsb_read(int
   */
  static int nforce2_set_fsb(unsigned int fsb)
  {
-	u32 pll, temp = 0;
+	u32 temp = 0;
  	unsigned int tfsb;
-	int diff;
+	int diff, pll = 0;

  	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
  		printk(KERN_ERR "cpufreq: FSB %d is out of range!\n", fsb);


-- 
Gabriel A. Devenyi
ace@staticwave.ca

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [KJ] [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@ 2005-11-08 12:38 ` Gabriel A. Devenyi
  0 siblings, 0 replies; 2+ messages in thread
From: Gabriel A. Devenyi @ 2005-11-08 12:38 UTC (permalink / raw)
  To: davej; +Cc: cpufreq, linux-kernel, kernel-janitors

Thanks to LinuxICC (http://linuxicc.sf.net), a comparison of a u32 less than 0 was found, this patch changes the variable to a signed int so that comparison is meaningful.

This patch applies to linus' git tree as of 02.11.2005

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

--
diff --git a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
index 04a4053..039297b 100644
--- a/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
+++ b/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
@@ -177,9 +177,9 @@ static unsigned int nforce2_fsb_read(int
   */
  static int nforce2_set_fsb(unsigned int fsb)
  {
-	u32 pll, temp = 0;
+	u32 temp = 0;
  	unsigned int tfsb;
-	int diff;
+	int diff, pll = 0;

  	if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
  		printk(KERN_ERR "cpufreq: FSB %d is out of range!\n", fsb);


-- 
Gabriel A. Devenyi
ace@staticwave.ca
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-08 12:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-08 12:38 [RESEND] [PATCH] arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c Gabriel A. Devenyi
2005-11-08 12:38 ` [KJ] " Gabriel A. Devenyi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.