All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Randy Dunlap <rdunlap@infradead.org>, davidgow <davidgow@google.com>
Cc: anton ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	tglx <tglx@linutronix.de>, mingo <mingo@redhat.com>,
	dave hansen <dave.hansen@linux.intel.com>,
	torvalds <torvalds@linux-foundation.org>,
	Brendan Higgins <brendan.higgins@linux.dev>,
	Daniel Latypov <dlatypov@google.com>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kunit-dev@googlegroups.com, x86 <x86@kernel.org>
Subject: Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning
Date: Mon, 19 Sep 2022 22:56:44 +0200 (CEST)	[thread overview]
Message-ID: <437983532.241061.1663621004742.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org>

----- Ursprüngliche Mail -----
> Von: "Randy Dunlap" <rdunlap@infradead.org>
>> Link:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ffcf9c5700e49c0aee42dcba9a12ba21338e8136
>> Link:
>> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
>> Signed-off-by: David Gow <davidgow@google.com>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

This patch causes a build error on one of my systems:

/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: unrecognized option '--no-warn-rwx-segments'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status

Just like in commit ffcf9c5700e4 ("x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments") you need to
test for it.

Thanks,
//richard

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Randy Dunlap <rdunlap@infradead.org>, davidgow <davidgow@google.com>
Cc: anton ivanov <anton.ivanov@cambridgegreys.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	tglx <tglx@linutronix.de>, mingo <mingo@redhat.com>,
	dave hansen <dave.hansen@linux.intel.com>,
	torvalds <torvalds@linux-foundation.org>,
	Brendan Higgins <brendan.higgins@linux.dev>,
	Daniel Latypov <dlatypov@google.com>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kunit-dev@googlegroups.com, x86 <x86@kernel.org>
Subject: Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning
Date: Mon, 19 Sep 2022 22:56:44 +0200 (CEST)	[thread overview]
Message-ID: <437983532.241061.1663621004742.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org>

----- Ursprüngliche Mail -----
> Von: "Randy Dunlap" <rdunlap@infradead.org>
>> Link:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ffcf9c5700e49c0aee42dcba9a12ba21338e8136
>> Link:
>> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
>> Signed-off-by: David Gow <davidgow@google.com>
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

This patch causes a build error on one of my systems:

/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: unrecognized option '--no-warn-rwx-segments'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status

Just like in commit ffcf9c5700e4 ("x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments") you need to
test for it.

Thanks,
//richard

  reply	other threads:[~2022-09-19 20:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  1:08 [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning David Gow
2022-08-23  1:08 ` David Gow
2022-08-26 15:39 ` Lukas Straub
2022-08-26 20:35 ` Randy Dunlap
2022-08-26 20:35   ` Randy Dunlap
2022-09-19 20:56   ` Richard Weinberger [this message]
2022-09-19 20:56     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437983532.241061.1663621004742.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=brendan.higgins@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=mingo@redhat.com \
    --cc=ndesaulniers@google.com \
    --cc=rdunlap@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.