From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira <pablo@eurodev.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: CTA_PROTO_NUM u_int8_t or u_int16_t
Date: Tue, 22 Nov 2005 05:42:05 +0100 [thread overview]
Message-ID: <4382A19D.9090201@trash.net> (raw)
In-Reply-To: <43820874.2050708@eurodev.net>
Pablo Neira wrote:
> Patrick McHardy wrote:
>
>>If you have to break compatibility, please do it before 2.6.15 is
>>released. But the easiest solution looks like keeping it a u_int16_t
>>and adjusting the NFA_PUT.
>
> I think that I can fix it in nf_conntrack_netlink. ip_conntrack_netlink
> will go sooner or later.
I'm not sure that will be an avantage to breaking it immediately.
People should be able to use ctnetlink application with nfctnetlink,
so it will still break, but at that point the interface will already
be more established. We could just leave it a u_int16_t, but it won't
be in network byte order as the other attributes, which IMO needs to
be fixed if we ever want to use ctnetlink over the network without
adding lots of code in userspace just to fix up this single field.
next prev parent reply other threads:[~2005-11-22 4:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 14:40 CTA_PROTO_NUM u_int8_t or u_int16_t Krzysztof Oledzki
2005-11-21 14:53 ` Pablo Neira
2005-11-21 17:03 ` Patrick McHardy
2005-11-21 17:48 ` Pablo Neira
2005-11-21 21:26 ` Krzysztof Oledzki
2005-11-22 4:42 ` Patrick McHardy [this message]
2005-11-22 19:04 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Pablo Neira
2005-11-22 20:29 ` Krzysztof Oledzki
2005-11-22 22:06 ` Harald Welte
2005-11-23 1:06 ` Patrick McHardy
2005-11-23 1:15 ` Pablo Neira
2005-11-23 9:47 ` Patrick McHardy
2005-11-23 10:31 ` Krzysztof Oledzki
2005-11-24 20:07 ` Harald Welte
2005-11-24 20:21 ` Harald Welte
2005-11-24 23:24 ` Krzysztof Oledzki
2005-11-24 23:33 ` Patrick McHardy
2005-11-24 23:54 ` Krzysztof Oledzki
2005-11-25 0:11 ` Patrick McHardy
2005-11-25 0:22 ` Pablo Neira
2005-11-25 0:26 ` Krzysztof Oledzki
2005-11-25 0:28 ` Krzysztof Oledzki
2005-11-25 8:44 ` Harald Welte
2005-11-25 9:23 ` Krzysztof Oledzki
2005-11-25 11:09 ` Harald Welte
2005-11-25 13:25 ` Patrick McHardy
2005-11-26 0:16 ` Pablo Neira Ayuso
2005-11-27 22:28 ` Krzysztof Oledzki
2005-11-29 4:09 ` Harald Welte
2005-11-29 23:07 ` Patrick McHardy
2005-12-04 3:31 ` Pablo Neira Ayuso
2005-12-04 16:05 ` Patrick McHardy
2005-12-04 16:35 ` Patrick McHardy
2005-12-04 19:48 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t David S. Miller
2005-12-04 20:02 ` Patrick McHardy
2005-12-04 20:20 ` David S. Miller
2005-12-13 9:56 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Krzysztof Oledzki
2005-12-13 11:22 ` Patrick McHardy
2005-12-13 11:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4382A19D.9090201@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.