From: Pablo Neira <pablo@eurodev.net>
To: Patrick McHardy <kaber@trash.net>
Cc: Harald Welte <laforge@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t)
Date: Fri, 25 Nov 2005 01:22:03 +0100 [thread overview]
Message-ID: <4386592B.1000905@eurodev.net> (raw)
In-Reply-To: <438656AE.9020307@trash.net>
Patrick McHardy wrote:
> Krzysztof Oledzki wrote:
>
>> Old binaries are not able to deal with CTA_PROTO and will not be able
>> to parse this attribute received from kernel. We should keep
>> CTA_PROTO_NUM here, but this leads to u_int8_t/u_int16_t mismatch in
>> the code.
>
> I didn't notice that, we of course need to dump both attributes. But I
> still think Pablo's suggestion is fine too and avoids all these hacks.
> The only people affected will be the ones not using the stable series.
Same feeling. I don't like the idea of breaking backward compatibility,
but in this case the hacks don't look really nice either :(. Since this
stuff was just pushed forward to 2.6.14, I still think that we should
send a patch to fix it in -stable.
--
Pablo
next prev parent reply other threads:[~2005-11-25 0:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 14:40 CTA_PROTO_NUM u_int8_t or u_int16_t Krzysztof Oledzki
2005-11-21 14:53 ` Pablo Neira
2005-11-21 17:03 ` Patrick McHardy
2005-11-21 17:48 ` Pablo Neira
2005-11-21 21:26 ` Krzysztof Oledzki
2005-11-22 4:42 ` Patrick McHardy
2005-11-22 19:04 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Pablo Neira
2005-11-22 20:29 ` Krzysztof Oledzki
2005-11-22 22:06 ` Harald Welte
2005-11-23 1:06 ` Patrick McHardy
2005-11-23 1:15 ` Pablo Neira
2005-11-23 9:47 ` Patrick McHardy
2005-11-23 10:31 ` Krzysztof Oledzki
2005-11-24 20:07 ` Harald Welte
2005-11-24 20:21 ` Harald Welte
2005-11-24 23:24 ` Krzysztof Oledzki
2005-11-24 23:33 ` Patrick McHardy
2005-11-24 23:54 ` Krzysztof Oledzki
2005-11-25 0:11 ` Patrick McHardy
2005-11-25 0:22 ` Pablo Neira [this message]
2005-11-25 0:26 ` Krzysztof Oledzki
2005-11-25 0:28 ` Krzysztof Oledzki
2005-11-25 8:44 ` Harald Welte
2005-11-25 9:23 ` Krzysztof Oledzki
2005-11-25 11:09 ` Harald Welte
2005-11-25 13:25 ` Patrick McHardy
2005-11-26 0:16 ` Pablo Neira Ayuso
2005-11-27 22:28 ` Krzysztof Oledzki
2005-11-29 4:09 ` Harald Welte
2005-11-29 23:07 ` Patrick McHardy
2005-12-04 3:31 ` Pablo Neira Ayuso
2005-12-04 16:05 ` Patrick McHardy
2005-12-04 16:35 ` Patrick McHardy
2005-12-04 19:48 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t David S. Miller
2005-12-04 20:02 ` Patrick McHardy
2005-12-04 20:20 ` David S. Miller
2005-12-13 9:56 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Krzysztof Oledzki
2005-12-13 11:22 ` Patrick McHardy
2005-12-13 11:32 ` Pablo Neira Ayuso
-- strict thread matches above, loose matches on Subject: below --
2005-12-13 11:26 [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t)] Patrick McHardy
2005-12-13 11:51 ` Krzysztof Oledzki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4386592B.1000905@eurodev.net \
--to=pablo@eurodev.net \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.