From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: laforge@netfilter.org, netfilter-devel@lists.netfilter.org,
pablo@eurodev.net
Subject: Re: [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t
Date: Sun, 04 Dec 2005 21:02:08 +0100 [thread overview]
Message-ID: <43934B40.60309@trash.net> (raw)
In-Reply-To: <20051204.114813.59310147.davem@davemloft.net>
David S. Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Sun, 04 Dec 2005 17:05:06 +0100
>
>
>>It doesn't even affect compatiblity, userspace can send both
>>u_int8_t or u_int16_t, the binary representation will look the same.
>
>
> On little-endian, yes. But on big-endian you'll get a byte-swapped
> value for the case where userspace sends in a u8.
Yes. Unfortunately we don't have much choice because kernel and
userspace use both u_int8_t and u_int16_t for CTA_PROTO_NUM. Some
ugly workarounds might be possible, but considering that ctnetlink
is new and how much problems it still has, it shouldn't be a big
problem to do this right and break compatibility.
next prev parent reply other threads:[~2005-12-04 20:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 14:40 CTA_PROTO_NUM u_int8_t or u_int16_t Krzysztof Oledzki
2005-11-21 14:53 ` Pablo Neira
2005-11-21 17:03 ` Patrick McHardy
2005-11-21 17:48 ` Pablo Neira
2005-11-21 21:26 ` Krzysztof Oledzki
2005-11-22 4:42 ` Patrick McHardy
2005-11-22 19:04 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Pablo Neira
2005-11-22 20:29 ` Krzysztof Oledzki
2005-11-22 22:06 ` Harald Welte
2005-11-23 1:06 ` Patrick McHardy
2005-11-23 1:15 ` Pablo Neira
2005-11-23 9:47 ` Patrick McHardy
2005-11-23 10:31 ` Krzysztof Oledzki
2005-11-24 20:07 ` Harald Welte
2005-11-24 20:21 ` Harald Welte
2005-11-24 23:24 ` Krzysztof Oledzki
2005-11-24 23:33 ` Patrick McHardy
2005-11-24 23:54 ` Krzysztof Oledzki
2005-11-25 0:11 ` Patrick McHardy
2005-11-25 0:22 ` Pablo Neira
2005-11-25 0:26 ` Krzysztof Oledzki
2005-11-25 0:28 ` Krzysztof Oledzki
2005-11-25 8:44 ` Harald Welte
2005-11-25 9:23 ` Krzysztof Oledzki
2005-11-25 11:09 ` Harald Welte
2005-11-25 13:25 ` Patrick McHardy
2005-11-26 0:16 ` Pablo Neira Ayuso
2005-11-27 22:28 ` Krzysztof Oledzki
2005-11-29 4:09 ` Harald Welte
2005-11-29 23:07 ` Patrick McHardy
2005-12-04 3:31 ` Pablo Neira Ayuso
2005-12-04 16:05 ` Patrick McHardy
2005-12-04 16:35 ` Patrick McHardy
2005-12-04 19:48 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t David S. Miller
2005-12-04 20:02 ` Patrick McHardy [this message]
2005-12-04 20:20 ` David S. Miller
2005-12-13 9:56 ` [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Krzysztof Oledzki
2005-12-13 11:22 ` Patrick McHardy
2005-12-13 11:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43934B40.60309@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@eurodev.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.