From: Andy Whitcroft <apw@shadowen.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andi Kleen <ak@suse.de>,
linux-mm@kvack.org, mingo@elte.hu,
lhms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
nickpiggin@yahoo.com.au
Subject: Re: [PATCH 2/5] Light Fragmentation Avoidance V20: 002_usemap
Date: Tue, 22 Nov 2005 10:13:28 +0000 [thread overview]
Message-ID: <4382EF48.1050107@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0511160200530.8470@skynet>
Mel Gorman wrote:
> That's iterating through, potentially, 1024 pages which I considered too
> expensive. In terms of code complexity, the page-flags patch adds 237
> which is not much of a saving in comparison to 275 that the usemap
> approach uses.
Surley you would just use a single bit in the first page of a MAX_ORDER
block. We guarentee that the mem_map is contigious out to MAX_ORDER
pages so you can simply calculate the offset. The page free path does
the same thing to find the buddy pages when coallescing.
> Again, I can revisit the page-flag approach if I thought that something
> like this would get merged and people would not choke on another page flag
> being consumed.
All of that said, I am not even sure we have a bit left in the page
flags on smaller architectures :/.
-apw
WARNING: multiple messages have this Message-ID (diff)
From: Andy Whitcroft <apw@shadowen.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Andi Kleen <ak@suse.de>,
linux-mm@kvack.org, mingo@elte.hu,
lhms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
nickpiggin@yahoo.com.au
Subject: Re: [PATCH 2/5] Light Fragmentation Avoidance V20: 002_usemap
Date: Tue, 22 Nov 2005 10:13:28 +0000 [thread overview]
Message-ID: <4382EF48.1050107@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0511160200530.8470@skynet>
Mel Gorman wrote:
> That's iterating through, potentially, 1024 pages which I considered too
> expensive. In terms of code complexity, the page-flags patch adds 237
> which is not much of a saving in comparison to 275 that the usemap
> approach uses.
Surley you would just use a single bit in the first page of a MAX_ORDER
block. We guarentee that the mem_map is contigious out to MAX_ORDER
pages so you can simply calculate the offset. The page free path does
the same thing to find the buddy pages when coallescing.
> Again, I can revisit the page-flag approach if I thought that something
> like this would get merged and people would not choke on another page flag
> being consumed.
All of that said, I am not even sure we have a bit left in the page
flags on smaller architectures :/.
-apw
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-22 10:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-15 16:49 [PATCH 0/5] Light Fragmentation Avoidance V20 Mel Gorman
2005-11-15 16:49 ` Mel Gorman
2005-11-15 16:49 ` [PATCH 1/5] Light Fragmentation Avoidance V20: 001_antidefrag_flags Mel Gorman
2005-11-15 16:49 ` Mel Gorman
2005-11-15 23:00 ` Paul Jackson
2005-11-15 23:00 ` Paul Jackson
2005-11-15 23:04 ` Randy.Dunlap
2005-11-15 23:04 ` Randy.Dunlap
2005-11-16 1:36 ` Mel Gorman
2005-11-16 1:36 ` Mel Gorman
2005-11-20 14:45 ` [Lhms-devel] " Paul Jackson
2005-11-20 14:45 ` Paul Jackson
2005-11-15 16:49 ` [PATCH 2/5] Light Fragmentation Avoidance V20: 002_usemap Mel Gorman
2005-11-15 16:49 ` Mel Gorman
2005-11-15 23:36 ` Andi Kleen
2005-11-15 23:36 ` Andi Kleen
2005-11-16 1:43 ` Mel Gorman
2005-11-16 1:43 ` Mel Gorman
2005-11-16 1:52 ` Andi Kleen
2005-11-16 1:52 ` Andi Kleen
2005-11-16 2:07 ` Mel Gorman
2005-11-16 2:07 ` Mel Gorman
2005-11-22 10:13 ` Andy Whitcroft [this message]
2005-11-22 10:13 ` Andy Whitcroft
2005-11-22 10:19 ` Mel Gorman
2005-11-22 10:19 ` Mel Gorman
2005-11-22 10:22 ` Andi Kleen
2005-11-22 10:22 ` Andi Kleen
2005-11-22 10:35 ` Mel Gorman
2005-11-22 10:35 ` Mel Gorman
2005-11-22 10:48 ` KAMEZAWA Hiroyuki
2005-11-22 10:48 ` KAMEZAWA Hiroyuki
2005-11-22 19:40 ` Mel Gorman
2005-11-22 19:40 ` Mel Gorman
2005-11-22 10:54 ` KAMEZAWA Hiroyuki
2005-11-22 10:54 ` KAMEZAWA Hiroyuki
2005-11-22 11:10 ` Mel Gorman
2005-11-22 11:10 ` Mel Gorman
2005-11-22 11:35 ` Mel Gorman
2005-11-22 11:35 ` Mel Gorman
2005-11-15 16:50 ` [PATCH 3/5] Light Fragmentation Avoidance V20: 003_fragcore Mel Gorman
2005-11-15 16:50 ` Mel Gorman
2005-11-16 2:35 ` KAMEZAWA Hiroyuki
2005-11-16 2:35 ` KAMEZAWA Hiroyuki
2005-11-16 10:42 ` Mel Gorman
2005-11-16 10:42 ` Mel Gorman
2005-11-15 16:50 ` [PATCH 4/5] Light Fragmentation Avoidance V20: 004_percpu Mel Gorman
2005-11-15 16:50 ` Mel Gorman
2005-11-15 23:24 ` Paul Jackson
2005-11-15 23:24 ` Paul Jackson
2005-11-16 1:37 ` Mel Gorman
2005-11-16 1:37 ` Mel Gorman
2005-11-15 16:50 ` [PATCH 5/5] Light Fragmentation Avoidance V20: 005_configurable Mel Gorman
2005-11-15 16:50 ` Mel Gorman
2005-11-15 23:39 ` Andi Kleen
2005-11-15 23:39 ` Andi Kleen
2005-11-16 1:47 ` Mel Gorman
2005-11-16 1:47 ` Mel Gorman
2005-11-15 22:54 ` [PATCH 0/5] Light Fragmentation Avoidance V20 Paul Jackson
2005-11-15 22:54 ` Paul Jackson
2005-11-16 1:34 ` Mel Gorman
2005-11-16 1:34 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4382EF48.1050107@shadowen.org \
--to=apw@shadowen.org \
--cc=ak@suse.de \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.