* [PATCH] [POM-NG] missing spin_unlock_bh in u32 match
@ 2005-11-25 3:07 Pablo Neira Ayuso
2005-11-26 23:53 ` Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2005-11-25 3:07 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Harald Welte
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Fix missing spin_unlock_bh in exit path in u32. This problem only
affects the 2.6 branch.
--
Pablo
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 608 bytes --]
Index: patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c
===================================================================
--- patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c (revision 4547)
+++ patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c (working copy)
@@ -166,8 +166,10 @@
case IPT_U32_AT:
AttPos += val;
pos = number;
- if (AttPos + pos + 3 > skb->len || AttPos + pos < 0)
+ if (AttPos + pos + 3 > skb->len || AttPos + pos < 0) {
+ spin_unlock_bh(&u32_lock);
return 0;
+ }
val = (base[AttPos + pos]<<24)
+(base[AttPos + pos + 1]<<16)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-26 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-25 3:07 [PATCH] [POM-NG] missing spin_unlock_bh in u32 match Pablo Neira Ayuso
2005-11-26 23:53 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.