All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: mathias.kretschmer@fokus.fraunhofer.de, kgiori@qca.qualcomm.com,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCHv2 2/2] ath10k: add spectral scan feature
Date: Mon, 21 Jul 2014 21:02:47 +0200	[thread overview]
Message-ID: <43945028.YYV8n3Af3F@sven-edge> (raw)
In-Reply-To: <1405945943-8303-3-git-send-email-sw@simonwunderlich.de>

On Monday 21 July 2014 14:32:23 Simon Wunderlich wrote:
> diff --git a/drivers/net/wireless/ath/ath10k/Makefile
> b/drivers/net/wireless/ath/ath10k/Makefile index 2110a5c..e1dcefd 100644
> --- a/drivers/net/wireless/ath/ath10k/Makefile
> +++ b/drivers/net/wireless/ath/ath10k/Makefile
> @@ -8,7 +8,8 @@ ath10k_core-y += mac.o \
>  		 htt_tx.o \
>  		 txrx.o \
>  		 wmi.o \
> -		 bmi.o
> +		 bmi.o \
> +		 spectral.o


ath9k doesn't compile the debugfs+spectral source files when 
CONFIG_ATH9K_DEBUGFS is not enabled. So this most likely has to be changed to 

ath10k_core-$(CONFIG_ATH10K_DEBUGFS) += spectral.o

Otherwise the static inline functions in the spectral.h may collide with the 
functions inside spectral.c when CONFIG_ATH10K_DEBUGFS is disabled.

Kind regards,
	Sven

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	kgiori@qca.qualcomm.com, mathias.kretschmer@fokus.fraunhofer.de
Subject: Re: [PATCHv2 2/2] ath10k: add spectral scan feature
Date: Mon, 21 Jul 2014 21:02:47 +0200	[thread overview]
Message-ID: <43945028.YYV8n3Af3F@sven-edge> (raw)
In-Reply-To: <1405945943-8303-3-git-send-email-sw@simonwunderlich.de>

On Monday 21 July 2014 14:32:23 Simon Wunderlich wrote:
> diff --git a/drivers/net/wireless/ath/ath10k/Makefile
> b/drivers/net/wireless/ath/ath10k/Makefile index 2110a5c..e1dcefd 100644
> --- a/drivers/net/wireless/ath/ath10k/Makefile
> +++ b/drivers/net/wireless/ath/ath10k/Makefile
> @@ -8,7 +8,8 @@ ath10k_core-y += mac.o \
>  		 htt_tx.o \
>  		 txrx.o \
>  		 wmi.o \
> -		 bmi.o
> +		 bmi.o \
> +		 spectral.o


ath9k doesn't compile the debugfs+spectral source files when 
CONFIG_ATH9K_DEBUGFS is not enabled. So this most likely has to be changed to 

ath10k_core-$(CONFIG_ATH10K_DEBUGFS) += spectral.o

Otherwise the static inline functions in the spectral.h may collide with the 
functions inside spectral.c when CONFIG_ATH10K_DEBUGFS is disabled.

Kind regards,
	Sven

  parent reply	other threads:[~2014-07-21 19:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 12:32 [PATCHv2 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-21 12:32 ` Simon Wunderlich
2014-07-21 12:32 ` [PATCHv2 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-21 12:32   ` Simon Wunderlich
2014-07-21 12:32 ` [PATCHv2 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-21 12:32   ` Simon Wunderlich
2014-07-21 18:35   ` Kalle Valo
2014-07-21 18:35     ` Kalle Valo
2014-07-21 19:02   ` Sven Eckelmann [this message]
2014-07-21 19:02     ` Sven Eckelmann
2014-07-22  8:07   ` Michal Kazior
2014-07-22  8:07     ` Michal Kazior
2014-07-22 18:27   ` Kalle Valo
2014-07-22 18:27     ` Kalle Valo
2014-07-23 15:12     ` Simon Wunderlich
2014-07-23 15:12       ` Simon Wunderlich
2014-07-23 16:34       ` Kalle Valo
2014-07-23 16:34         ` Kalle Valo
2014-07-23 16:40         ` Simon Wunderlich
2014-07-23 16:40           ` Simon Wunderlich
2014-07-23 16:44           ` Kalle Valo
2014-07-23 16:44             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43945028.YYV8n3Af3F@sven-edge \
    --to=sven@narfation.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kgiori@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathias.kretschmer@fokus.fraunhofer.de \
    --cc=sw@simonwunderlich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.