From: Jeff Mahoney <jeffm@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: including <asm/signal.h> alone causes compilation
Date: Mon, 09 Jan 2006 17:32:51 +0000 [thread overview]
Message-ID: <43C29E43.8030405@suse.com> (raw)
In-Reply-To: <20060109172554.GA3026@infradead.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Christoph Hellwig wrote:
> On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote:
>> Including *just* <asm/signal.h> on ia64 will result in a compilation failure,
>> where it will succeed on every other architecture.
>>
>> Every other arch includes <linux/compiler.h> either directly or via
>> <linux/types.h> at the top of <asm-*/signal.h>. ia64 includes
>> <linux/types.h> after including <asm-generic/signal.h>, which causes
>> the __user in <asm-generic/signal.h> to get passed through untouched, causing
>> compilation errors.
>>
>> This patch moves the #include <linux/types.h> up to the beginning of signal.h,
>> as found on every other arch.
>>
>> A specific example of where this behavior is observed is the recent addition
>> of OCFS2. fs/ocfs2/cluster/userdlm.c seems alone in only including
>> <asm/signal.h>, which seems to be perfectly valid.
>
> Generally you should only include <asm/signal.h> via <linux/signal.h>, which gets
> <linux/compiler.h> via <linux/spinlock.h>
Ok. I just did a quick grep and saw a number of places where
<asm/signal.h> was included. A closer look reveals most of those are in
arch/.
Ignore the noise.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDwp5DLPWxlyuTD7IRAoZBAKCf4MMQNC/rfcdXOH0Dto3RTa32qgCfSeFf
pX68kyrbj2ZdH23Mo+EmUZ4=y7xp
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Mahoney <jeffm@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: including <asm/signal.h> alone causes compilation errors
Date: Mon, 09 Jan 2006 12:32:51 -0500 [thread overview]
Message-ID: <43C29E43.8030405@suse.com> (raw)
In-Reply-To: <20060109172554.GA3026@infradead.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Christoph Hellwig wrote:
> On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote:
>> Including *just* <asm/signal.h> on ia64 will result in a compilation failure,
>> where it will succeed on every other architecture.
>>
>> Every other arch includes <linux/compiler.h> either directly or via
>> <linux/types.h> at the top of <asm-*/signal.h>. ia64 includes
>> <linux/types.h> after including <asm-generic/signal.h>, which causes
>> the __user in <asm-generic/signal.h> to get passed through untouched, causing
>> compilation errors.
>>
>> This patch moves the #include <linux/types.h> up to the beginning of signal.h,
>> as found on every other arch.
>>
>> A specific example of where this behavior is observed is the recent addition
>> of OCFS2. fs/ocfs2/cluster/userdlm.c seems alone in only including
>> <asm/signal.h>, which seems to be perfectly valid.
>
> Generally you should only include <asm/signal.h> via <linux/signal.h>, which gets
> <linux/compiler.h> via <linux/spinlock.h>
Ok. I just did a quick grep and saw a number of places where
<asm/signal.h> was included. A closer look reveals most of those are in
arch/.
Ignore the noise.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDwp5DLPWxlyuTD7IRAoZBAKCf4MMQNC/rfcdXOH0Dto3RTa32qgCfSeFf
pX68kyrbj2ZdH23Mo+EmUZ4=
=y7xp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2006-01-09 17:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 17:15 [PATCH] ia64: including <asm/signal.h> alone causes compilation errors Jeff Mahoney
2006-01-09 17:15 ` Jeff Mahoney
2006-01-09 17:21 ` Matthew Wilcox
2006-01-09 17:21 ` Matthew Wilcox
2006-01-09 17:42 ` [PATCH] ia64: including <asm/signal.h> alone causes compilation Jeff Mahoney
2006-01-09 17:42 ` [PATCH] ia64: including <asm/signal.h> alone causes compilation errors Jeff Mahoney
2006-01-09 17:25 ` Christoph Hellwig
2006-01-09 17:25 ` Christoph Hellwig
2006-01-09 17:32 ` Jeff Mahoney [this message]
2006-01-09 17:32 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C29E43.8030405@suse.com \
--to=jeffm@suse.com \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.