From: Jeff Mahoney <jeffm@suse.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: including <asm/signal.h> alone causes compilation
Date: Mon, 09 Jan 2006 17:42:59 +0000 [thread overview]
Message-ID: <43C2A0A3.8070901@suse.com> (raw)
In-Reply-To: <20060109172149.GQ19769@parisc-linux.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matthew Wilcox wrote:
> On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote:
>> +++ linux-2.6.15-ocfs2/include/asm-ia64/signal.h 2006-01-09 11:08:16.404700640 -0500
>> @@ -1,6 +1,8 @@
>> #ifndef _ASM_IA64_SIGNAL_H
>> #define _ASM_IA64_SIGNAL_H
>>
>> +#include <linux/types.h>
>> +
>> /*
>> * Modified 1998-2001, 2003
>> * David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co
>> @@ -122,8 +124,6 @@
>>
>> # ifndef __ASSEMBLY__
>>
>> -# include <linux/types.h>
>> -
>> /* Avoid too many header ordering problems. */
>> struct siginfo;
>
> Is it still possible to include this file from assembly? Do we still
> need to do that?
>
>
Yes, actually, it is. :(
Christoph also pointed out that including <linux/signal.h> is the better
solution, so I'm submitting that patch to the OCFS2 folks instead.
Sorry for the noise.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDwqCjLPWxlyuTD7IRAj8PAJwLv2EghfMR9yPuaVhpTLQMGysKpwCfcVBq
7ZT0LwuYEjKYVnJT/QeXmCw=Yt8o
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Mahoney <jeffm@suse.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-ia64@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ia64: including <asm/signal.h> alone causes compilation errors
Date: Mon, 09 Jan 2006 12:42:59 -0500 [thread overview]
Message-ID: <43C2A0A3.8070901@suse.com> (raw)
In-Reply-To: <20060109172149.GQ19769@parisc-linux.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matthew Wilcox wrote:
> On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote:
>> +++ linux-2.6.15-ocfs2/include/asm-ia64/signal.h 2006-01-09 11:08:16.404700640 -0500
>> @@ -1,6 +1,8 @@
>> #ifndef _ASM_IA64_SIGNAL_H
>> #define _ASM_IA64_SIGNAL_H
>>
>> +#include <linux/types.h>
>> +
>> /*
>> * Modified 1998-2001, 2003
>> * David Mosberger-Tang <davidm@hpl.hp.com>, Hewlett-Packard Co
>> @@ -122,8 +124,6 @@
>>
>> # ifndef __ASSEMBLY__
>>
>> -# include <linux/types.h>
>> -
>> /* Avoid too many header ordering problems. */
>> struct siginfo;
>
> Is it still possible to include this file from assembly? Do we still
> need to do that?
>
>
Yes, actually, it is. :(
Christoph also pointed out that including <linux/signal.h> is the better
solution, so I'm submitting that patch to the OCFS2 folks instead.
Sorry for the noise.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFDwqCjLPWxlyuTD7IRAj8PAJwLv2EghfMR9yPuaVhpTLQMGysKpwCfcVBq
7ZT0LwuYEjKYVnJT/QeXmCw=
=Yt8o
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2006-01-09 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-09 17:15 [PATCH] ia64: including <asm/signal.h> alone causes compilation errors Jeff Mahoney
2006-01-09 17:15 ` Jeff Mahoney
2006-01-09 17:21 ` Matthew Wilcox
2006-01-09 17:21 ` Matthew Wilcox
2006-01-09 17:42 ` Jeff Mahoney [this message]
2006-01-09 17:42 ` Jeff Mahoney
2006-01-09 17:25 ` Christoph Hellwig
2006-01-09 17:25 ` Christoph Hellwig
2006-01-09 17:32 ` [PATCH] ia64: including <asm/signal.h> alone causes compilation Jeff Mahoney
2006-01-09 17:32 ` [PATCH] ia64: including <asm/signal.h> alone causes compilation errors Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C2A0A3.8070901@suse.com \
--to=jeffm@suse.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.