From: Sean Hefty <mshefty@ichips.intel.com>
To: Grant Grundler <iod00d@hp.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [openib-general] RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction
Date: Wed, 18 Jan 2006 09:46:03 -0800 [thread overview]
Message-ID: <43CE7EDB.7030201@ichips.intel.com> (raw)
In-Reply-To: <20060118020342.GB3740@esmail.cup.hp.com>
Grant Grundler wrote:
>>+static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask)
>>+{
>>+ int i;
>>+
>>+ for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE; i++)
>>+ dst[i] = src[i] & mask[i];
>>+}
>
> Is this code going to get invoked very often?
In practice, it would be invoked when matching any listen requests originating
from the CMA (RDMA connection abstraction).
> If so, can the mask operation use a "native" size since
> IB_CM_PRIVATE_DATA_COMPARE_SIZE is hard coded to 64 byte?
>
> e.g something like:
> for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE/sizeof(unsigned long);
> i++)
> ((unsigned long *)dst)[i] = ((unsigned long *)src)[i]
> & ((unsigned long *)mask)[i];
Yes - something like this should work. Thanks.
- Sean
WARNING: multiple messages have this Message-ID (diff)
From: Sean Hefty <mshefty@ichips.intel.com>
To: Grant Grundler <iod00d@hp.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: RE: [PATCH 2/5] [RFC] Infiniband: connection abstraction
Date: Wed, 18 Jan 2006 09:46:03 -0800 [thread overview]
Message-ID: <43CE7EDB.7030201@ichips.intel.com> (raw)
In-Reply-To: <20060118020342.GB3740@esmail.cup.hp.com>
Grant Grundler wrote:
>>+static void cm_mask_compare_data(u8 *dst, u8 *src, u8 *mask)
>>+{
>>+ int i;
>>+
>>+ for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE; i++)
>>+ dst[i] = src[i] & mask[i];
>>+}
>
> Is this code going to get invoked very often?
In practice, it would be invoked when matching any listen requests originating
from the CMA (RDMA connection abstraction).
> If so, can the mask operation use a "native" size since
> IB_CM_PRIVATE_DATA_COMPARE_SIZE is hard coded to 64 byte?
>
> e.g something like:
> for (i = 0; i < IB_CM_PRIVATE_DATA_COMPARE_SIZE/sizeof(unsigned long);
> i++)
> ((unsigned long *)dst)[i] = ((unsigned long *)src)[i]
> & ((unsigned long *)mask)[i];
Yes - something like this should work. Thanks.
- Sean
next prev parent reply other threads:[~2006-01-18 17:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 23:16 [PATCH 0/5] [RFC] Infiniband: connection abstraction Sean Hefty
2006-01-17 23:16 ` Sean Hefty
2006-01-17 23:21 ` [PATCH 1/5] " Sean Hefty
2006-01-17 23:21 ` Sean Hefty
2006-01-17 23:24 ` [PATCH 2/5] " Sean Hefty
2006-01-17 23:38 ` Stephen Hemminger
2006-01-17 23:38 ` Stephen Hemminger
2006-01-17 23:51 ` Sean Hefty
2006-01-17 23:51 ` Sean Hefty
2006-01-18 7:08 ` Arjan van de Ven
2006-01-18 7:08 ` Arjan van de Ven
2006-01-18 20:27 ` Bryan O'Sullivan
2006-01-18 20:27 ` Bryan O'Sullivan
2006-01-18 2:03 ` [openib-general] " Grant Grundler
2006-01-18 2:03 ` Grant Grundler
2006-01-18 17:46 ` Sean Hefty [this message]
2006-01-18 17:46 ` Sean Hefty
2006-01-18 18:02 ` [openib-general] " Grant Grundler
2006-01-18 18:02 ` Grant Grundler
2006-01-18 18:13 ` [openib-general] " Sean Hefty
2006-01-18 18:13 ` Sean Hefty
2006-01-17 23:24 ` Sean Hefty
2006-01-17 23:28 ` [PATCH 3/5] " Sean Hefty
2006-01-17 23:28 ` Sean Hefty
2006-01-21 23:37 ` [openib-general] " Roland Dreier
2006-01-21 23:37 ` Roland Dreier
2006-01-17 23:37 ` [PATCH 4/5] " Sean Hefty
2006-01-17 23:37 ` Sean Hefty
2006-01-17 23:44 ` [PATCH 5/5] " Sean Hefty
2006-01-17 23:44 ` Sean Hefty
2006-01-18 15:43 ` [openib-general] " Roland Dreier
2006-01-18 15:43 ` Roland Dreier
2006-01-18 15:44 ` [openib-general] " Roland Dreier
2006-01-18 15:44 ` Roland Dreier
2006-01-18 18:19 ` [openib-general] " Sean Hefty
2006-01-18 18:19 ` Sean Hefty
2006-01-18 18:49 ` [openib-general] " Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CE7EDB.7030201@ichips.intel.com \
--to=mshefty@ichips.intel.com \
--cc=iod00d@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.