* ip_conntrack build warning
@ 2006-03-15 19:23 Stephen Hemminger
2006-03-15 23:50 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2006-03-15 19:23 UTC (permalink / raw)
To: netfilter-devel
Recent kernels in -mm warn about init section usage in ip_conntrack.
The problem is the init_or_cleanup() style makes it impossible to compile
time checking hard.
WARNING: net/ipv4/netfilter/ip_conntrack.o - Section mismatch:
reference to .init.text:ip_conntrack_init from .text.init_or_cleanup
after 'init_or_cleanup' (at offset 0x12)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ip_conntrack build warning
2006-03-15 19:23 ip_conntrack build warning Stephen Hemminger
@ 2006-03-15 23:50 ` Patrick McHardy
2006-03-15 23:52 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2006-03-15 23:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netfilter-devel
Stephen Hemminger wrote:
> Recent kernels in -mm warn about init section usage in ip_conntrack.
> The problem is the init_or_cleanup() style makes it impossible to compile
> time checking hard.
>
> WARNING: net/ipv4/netfilter/ip_conntrack.o - Section mismatch:
> reference to .init.text:ip_conntrack_init from .text.init_or_cleanup
> after 'init_or_cleanup' (at offset 0x12)
The code should be fine, although I'm not a big fan of these
functions either. ip_conntrack_init is marked __init and is
called from init_or_cleanup, which is not marked, but only
on the init path.
I'd happily take a patch which cleans up these functions (we
have lots of them in the netfilter code).
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-15 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-15 19:23 ip_conntrack build warning Stephen Hemminger
2006-03-15 23:50 ` Patrick McHardy
2006-03-15 23:52 ` Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.