[PATCH] AMD Au1x00: AC'97 controller is memory mapped

[PATCH] AMD Au1x00: AC'97 controller is memory mapped

[Sergei Shtylylov]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

Hello.

    AMD Au1x00 ALSA driver erroneously calls request_region() for AC'97 
controller registers -- the controller is actually memory mapped at addresses
0x10000000 thru 0x100FFFFF.

WBR, Sergei



[-- Attachment #2: Au1x00-ALSA-AC97-memory-mapped.patch --]
[-- Type: text/plain, Size: 795 bytes --]

diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index 6d8f8b3..aa9c5d5 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -561,12 +561,13 @@ snd_au1000_ac97_new(struct snd_au1000 *a
 		.read = snd_au1000_ac97_read,
 	};
 
-	if ((au1000->ac97_res_port = request_region(AC97C_CONFIG,
-	       		sizeof(struct au1000_ac97_reg), "Au1x00 AC97")) == NULL) {
+	if ((au1000->ac97_res_port = request_mem_region(CPHYSADDR(AC97C_CONFIG),
+	       		0x100000, "Au1x00 AC97")) == NULL) {
 		snd_printk(KERN_ERR "ALSA AC97: can't grap AC97 port\n");
 		return -EBUSY;
 	}
-	au1000->ac97_ioport = (struct au1000_ac97_reg *) au1000->ac97_res_port->start;
+	au1000->ac97_ioport = (struct au1000_ac97_reg *)
+		KSEG1ADDR(au1000->ac97_res_port->start);
 
 	spin_lock_init(&au1000->ac97_lock);
 

[PATCH] AMD Au1x00: AC'97 controller is memory mapped

[Sergei Shtylylov]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hello.

    Reposting with signoff which I constantly forget about... :-/

    AMD Au1x00 ALSA driver erroneously calls request_region() for AC'97
controller registers -- the controller is actually memory mapped at addresses
0x10000000 thru 0x100FFFFF.

WBR, Sergei

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>


[-- Attachment #2: Au1x00-ALSA-AC97-memory-mapped.patch --]
[-- Type: text/plain, Size: 796 bytes --]

diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index 6d8f8b3..aa9c5d5 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -561,12 +561,13 @@ snd_au1000_ac97_new(struct snd_au1000 *a
 		.read = snd_au1000_ac97_read,
 	};
 
-	if ((au1000->ac97_res_port = request_region(AC97C_CONFIG,
-	       		sizeof(struct au1000_ac97_reg), "Au1x00 AC97")) == NULL) {
+	if ((au1000->ac97_res_port = request_mem_region(CPHYSADDR(AC97C_CONFIG),
+	       		0x100000, "Au1x00 AC97")) == NULL) {
 		snd_printk(KERN_ERR "ALSA AC97: can't grap AC97 port\n");
 		return -EBUSY;
 	}
-	au1000->ac97_ioport = (struct au1000_ac97_reg *) au1000->ac97_res_port->start;
+	au1000->ac97_ioport = (struct au1000_ac97_reg *)
+		KSEG1ADDR(au1000->ac97_res_port->start);
 
 	spin_lock_init(&au1000->ac97_lock);
 

Re: [PATCH] AMD Au1x00: AC'97 controller is memory mapped

[Takashi Iwai]

At Tue, 21 Mar 2006 04:01:01 +0300,
Sergei Shtylylov wrote:
> 
> Hello.
> 
>     Reposting with signoff which I constantly forget about... :-/
> 
>     AMD Au1x00 ALSA driver erroneously calls request_region() for AC'97
> controller registers -- the controller is actually memory mapped at addresses
> 0x10000000 thru 0x100FFFFF.
> 
> WBR, Sergei
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

Thanks, applied both patches now (with signed-off :)


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642