* [PATCH] Au1550: make OSS drivers look pretty on loading
2006-03-27 8:32 ` Sergei Shtylylov
@ 2006-03-31 21:20 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2006-03-31 21:20 UTC (permalink / raw)
To: linux-mips; +Cc: Jordan Crouse, Manish Lachwani
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
Hello.
Calls to pr_info() without newlines caused the OSS drivers' load time
messages to be printed w/o any spacing...
WBR, Sergei
[-- Attachment #2: Au1550-OSS-print-newlines.patch --]
[-- Type: text/plain, Size: 1405 bytes --]
diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c
index f38e082..0ca90a0 100644
--- a/sound/oss/au1550_ac97.c
+++ b/sound/oss/au1550_ac97.c
@@ -1950,7 +1950,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
/* register devices */
@@ -2031,7 +2031,7 @@ au1550_probe(void)
s->codec_base_caps = rdcodec(s->codec, AC97_RESET);
s->codec_ext_caps = rdcodec(s->codec, AC97_EXTENDED_ID);
- pr_info("AC'97 Base/Extended ID = %04x/%04x",
+ pr_info("AC'97 Base/Extended ID = %04x/%04x\n",
s->codec_base_caps, s->codec_ext_caps);
if (!(s->codec_ext_caps & AC97_EXTID_VRA)) {
@@ -2047,7 +2047,7 @@ au1550_probe(void)
s->no_vra = 1;
}
if (s->no_vra)
- pr_info("no VRA, interpolating and decimating");
+ pr_info("no VRA, interpolating and decimating\n");
/* set mic to be the recording source */
val = SOUND_MASK_MIC;
diff --git a/sound/oss/au1550_i2s.c b/sound/oss/au1550_i2s.c
index 529b625..9907ac0 100644
--- a/sound/oss/au1550_i2s.c
+++ b/sound/oss/au1550_i2s.c
@@ -1897,7 +1897,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
/* register devices */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] Au1550: make OSS drivers look pretty on loading
@ 2006-04-02 16:25 Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2006-04-02 16:25 UTC (permalink / raw)
To: Linux-MIPS; +Cc: Jordan Crouse
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
Hello.
Calls to pr_info() without newlines caused the OSS drivers' load time
messages to be printed w/o any spacing...
WBR, Sergei
PS: Forgot the signoff line again when posting the patch on Friday:
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
[-- Attachment #2: Au1550-OSS-print-newlines.patch --]
[-- Type: text/plain, Size: 1403 bytes --]
diff --git a/sound/oss/au1550_ac97.c b/sound/oss/au1550_ac97.c
index f38e082..0ca90a0 100644
--- a/sound/oss/au1550_ac97.c
+++ b/sound/oss/au1550_ac97.c
@@ -1950,7 +1950,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_AC97_TX_CHAN, DBDMA_AC97_RX_CHAN);
/* register devices */
@@ -2031,7 +2031,7 @@ au1550_probe(void)
s->codec_base_caps = rdcodec(s->codec, AC97_RESET);
s->codec_ext_caps = rdcodec(s->codec, AC97_EXTENDED_ID);
- pr_info("AC'97 Base/Extended ID = %04x/%04x",
+ pr_info("AC'97 Base/Extended ID = %04x/%04x\n",
s->codec_base_caps, s->codec_ext_caps);
if (!(s->codec_ext_caps & AC97_EXTID_VRA)) {
@@ -2047,7 +2047,7 @@ au1550_probe(void)
s->no_vra = 1;
}
if (s->no_vra)
- pr_info("no VRA, interpolating and decimating");
+ pr_info("no VRA, interpolating and decimating\n");
/* set mic to be the recording source */
val = SOUND_MASK_MIC;
diff --git a/sound/oss/au1550_i2s.c b/sound/oss/au1550_i2s.c
index 529b625..9907ac0 100644
--- a/sound/oss/au1550_i2s.c
+++ b/sound/oss/au1550_i2s.c
@@ -1897,7 +1897,7 @@ au1550_probe(void)
goto err_dma2;
}
- pr_info("DAC: DMA%d, ADC: DMA%d", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
+ pr_info("DAC: DMA%d, ADC: DMA%d\n", DBDMA_I2S_TX_CHAN, DBDMA_I2S_RX_CHAN);
/* register devices */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-02 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-02 16:25 [PATCH] Au1550: make OSS drivers look pretty on loading Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2006-03-27 7:43 [PATCH] small time list process error in prom_getenv() Freddy Spierenburg
2006-03-27 8:32 ` Sergei Shtylylov
2006-03-31 21:20 ` [PATCH] Au1550: make OSS drivers look pretty on loading Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.