From: Timur Tabi <timur@codeaurora.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Antoine Ténart" <antoine.tenart@free-electrons.com>,
"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
"Nadav Haklai" <nadavh@marvell.com>
Subject: Re: linux-next regression caused by "gpiolib: request the gpio before querying its direction"
Date: Wed, 30 Aug 2017 09:22:55 -0500 [thread overview]
Message-ID: <442accaa-15a0-4efb-4e5c-cebca7140213@codeaurora.org> (raw)
In-Reply-To: <20170830161730.41919554@windsurf.lan>
On 8/30/17 9:17 AM, Thomas Petazzoni wrote:
> So what Timur is saying perhaps is that
> mvebu_pinmux_gpio_request_enable() shouldn't be changing the type of
> muxing, and therefore shouldn't be calling mvebu_pinconf_group_set().
>
> However, even the "reference" pinctrl-single.c implementation does it,
> in pcs_request_gpio().
>
> Am I missing something ?
No, that's it. The question is, what exactly should the 'request'
function do? Should it be modifying the hardware to satisfy the
request? When I wrote my patch, I assumed that it wouldn't. I thought
that request simply answered the question, "can I touch this GPIO"?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next regression caused by "gpiolib: request the gpio before querying its direction"
Date: Wed, 30 Aug 2017 09:22:55 -0500 [thread overview]
Message-ID: <442accaa-15a0-4efb-4e5c-cebca7140213@codeaurora.org> (raw)
In-Reply-To: <20170830161730.41919554@windsurf.lan>
On 8/30/17 9:17 AM, Thomas Petazzoni wrote:
> So what Timur is saying perhaps is that
> mvebu_pinmux_gpio_request_enable() shouldn't be changing the type of
> muxing, and therefore shouldn't be calling mvebu_pinconf_group_set().
>
> However, even the "reference" pinctrl-single.c implementation does it,
> in pcs_request_gpio().
>
> Am I missing something ?
No, that's it. The question is, what exactly should the 'request'
function do? Should it be modifying the hardware to satisfy the
request? When I wrote my patch, I assumed that it wouldn't. I thought
that request simply answered the question, "can I touch this GPIO"?
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2017-08-30 14:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 9:24 linux-next regression caused by "gpiolib: request the gpio before querying its direction" Thomas Petazzoni
2017-08-30 9:24 ` Thomas Petazzoni
2017-08-30 12:31 ` Timur Tabi
2017-08-30 12:31 ` Timur Tabi
2017-08-30 13:59 ` Gregory CLEMENT
2017-08-30 13:59 ` Gregory CLEMENT
2017-08-30 14:17 ` Thomas Petazzoni
2017-08-30 14:17 ` Thomas Petazzoni
2017-08-30 14:22 ` Timur Tabi [this message]
2017-08-30 14:22 ` Timur Tabi
2017-08-30 14:32 ` Thomas Petazzoni
2017-08-30 14:32 ` Thomas Petazzoni
2017-08-30 16:24 ` jmondi
2017-08-30 16:24 ` jmondi
2017-08-30 19:38 ` Geert Uytterhoeven
2017-08-30 19:38 ` Geert Uytterhoeven
2017-08-31 7:08 ` Linus Walleij
2017-08-31 7:08 ` Linus Walleij
2017-08-31 7:18 ` Thomas Petazzoni
2017-08-31 7:18 ` Thomas Petazzoni
2017-08-31 7:30 ` Geert Uytterhoeven
2017-08-31 7:30 ` Geert Uytterhoeven
2017-08-31 9:22 ` Russell King - ARM Linux
2017-08-31 9:22 ` Russell King - ARM Linux
2017-08-31 9:39 ` Thomas Petazzoni
2017-08-31 9:39 ` Thomas Petazzoni
2017-08-31 18:39 ` Timur Tabi
2017-08-31 18:39 ` Timur Tabi
2017-08-31 9:50 ` Geert Uytterhoeven
2017-08-31 9:50 ` Geert Uytterhoeven
2017-08-31 13:05 ` Timur Tabi
2017-08-31 13:05 ` Timur Tabi
2017-08-31 10:08 ` Maxime Ripard
2017-08-31 10:08 ` Maxime Ripard
2017-08-31 7:04 ` Linus Walleij
2017-08-31 7:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442accaa-15a0-4efb-4e5c-cebca7140213@codeaurora.org \
--to=timur@codeaurora.org \
--cc=antoine.tenart@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=nadavh@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.