* EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL
@ 2006-05-22 16:01 Patrick McHardy
2006-05-22 23:49 ` Yasuyuki KOZAKAI
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2006-05-22 16:01 UTC (permalink / raw)
To: yasuyuki.kozakai; +Cc: Netfilter Development Mailinglist
Hi Yasuyuki,
while doing some stupid cleanup work on the conntrack code (moving
all EXPORT_SYMBOLs next to the exported function) I noticed
nf_conntrack uses EXPORT_SYMBOL for the exact same functions that
are EXPORT_SYMBOL_GPL'ed by ip_conntrack. I think we should change
it to _GPL too for consistency and because most of them mess deeply
inside the internals of conntrack.
Any objections to this change?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL
2006-05-22 16:01 EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL Patrick McHardy
@ 2006-05-22 23:49 ` Yasuyuki KOZAKAI
0 siblings, 0 replies; 2+ messages in thread
From: Yasuyuki KOZAKAI @ 2006-05-22 23:49 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, yasuyuki.kozakai
Hi, Patrick,
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 22 May 2006 18:01:23 +0200
> Hi Yasuyuki,
>
> while doing some stupid cleanup work on the conntrack code (moving
> all EXPORT_SYMBOLs next to the exported function) I noticed
> nf_conntrack uses EXPORT_SYMBOL for the exact same functions that
> are EXPORT_SYMBOL_GPL'ed by ip_conntrack. I think we should change
> it to _GPL too for consistency and because most of them mess deeply
> inside the internals of conntrack.
>
> Any objections to this change?
No objection, thanks for this cleanup.
-- Yasuyuki Kozakai
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-22 23:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-22 16:01 EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL Patrick McHardy
2006-05-22 23:49 ` Yasuyuki KOZAKAI
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.