[PATCH] qla1280: fix section mismatch warnings

[PATCH] qla1280: fix section mismatch warnings

[Randy.Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix section mismatch warnings:
WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
.init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
and 'qla1280_probe_one'
WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
.init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
and 'qla1280_probe_one'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/scsi/qla1280.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2617-rc5.orig/drivers/scsi/qla1280.c
+++ linux-2617-rc5/drivers/scsi/qla1280.c
@@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
  *  QLogic Driver Support Function Prototypes.
  */
 static void qla1280_done(struct scsi_qla_host *);
-static int qla1280_get_token(char *);
+static int qla1280_get_token(char *) __init;
 static int qla1280_setup(char *s) __init;
 
 /*
@@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
 }
 
 
-static int
+static int __init
 qla1280_get_token(char *str)
 {
 	char *sep;


---

Re: [PATCH] qla1280: fix section mismatch warnings

[İsmail Dönmez]

Randy.Dunlap wrote On 25-05-2006 20:39:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section mismatch warnings:
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> and 'qla1280_probe_one'
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> and 'qla1280_probe_one'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/qla1280.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Ack, fixes the warning for me. Thanks Randy!

Regards,
ismail

Re: [PATCH] qla1280: fix section mismatch warnings

[Andrew Morton]

"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix section mismatch warnings:
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> and 'qla1280_probe_one'
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> and 'qla1280_probe_one'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  drivers/scsi/qla1280.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2617-rc5.orig/drivers/scsi/qla1280.c
> +++ linux-2617-rc5/drivers/scsi/qla1280.c
> @@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
>   *  QLogic Driver Support Function Prototypes.
>   */
>  static void qla1280_done(struct scsi_qla_host *);
> -static int qla1280_get_token(char *);
> +static int qla1280_get_token(char *) __init;

We don't normally put section tags on declarations.  So I dropped this hunk
- unless you see a need for it?

>  static int qla1280_setup(char *s) __init;

OK, for consistency.   But let's not be consistent with inconsistent stuff ;)

>  /*
> @@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
>  }
>  
>  
> -static int
> +static int __init
>  qla1280_get_token(char *str)
>  {
>  	char *sep;

And that's not really a bugfix - it's just a save-a-bit-of-memory fix.

Re: [PATCH] qla1280: fix section mismatch warnings

[Randy.Dunlap]

On Thu, 25 May 2006 14:46:33 -0700 Andrew Morton wrote:

> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> > From: Randy Dunlap <rdunlap@xenotime.net>
> > 
> > Fix section mismatch warnings:
> > WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> > .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> > and 'qla1280_probe_one'
> > WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> > .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> > and 'qla1280_probe_one'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> >  drivers/scsi/qla1280.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux-2617-rc5.orig/drivers/scsi/qla1280.c
> > +++ linux-2617-rc5/drivers/scsi/qla1280.c
> > @@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
> >   *  QLogic Driver Support Function Prototypes.
> >   */
> >  static void qla1280_done(struct scsi_qla_host *);
> > -static int qla1280_get_token(char *);
> > +static int qla1280_get_token(char *) __init;
> 
> We don't normally put section tags on declarations.  So I dropped this hunk
> - unless you see a need for it?
> 
> >  static int qla1280_setup(char *s) __init;
> 
> OK, for consistency.   But let's not be consistent with inconsistent stuff ;)

Right. :)

> >  /*
> > @@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
> >  }
> >  
> >  
> > -static int
> > +static int __init
> >  qla1280_get_token(char *str)
> >  {
> >  	char *sep;
> 
> And that's not really a bugfix - it's just a save-a-bit-of-memory fix.

Yes, that's accurate.  

I'll start noting severity levels...

---
~Randy