* [PATCH] qla1280: fix section mismatch warnings
@ 2006-05-25 17:39 Randy.Dunlap
2006-05-25 17:41 ` İsmail Dönmez
2006-05-25 21:46 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-05-25 17:39 UTC (permalink / raw)
To: ismail, scsi; +Cc: akpm, jejb, jes
From: Randy Dunlap <rdunlap@xenotime.net>
Fix section mismatch warnings:
WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
.init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
and 'qla1280_probe_one'
WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
.init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
and 'qla1280_probe_one'
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/scsi/qla1280.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--- linux-2617-rc5.orig/drivers/scsi/qla1280.c
+++ linux-2617-rc5/drivers/scsi/qla1280.c
@@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
* QLogic Driver Support Function Prototypes.
*/
static void qla1280_done(struct scsi_qla_host *);
-static int qla1280_get_token(char *);
+static int qla1280_get_token(char *) __init;
static int qla1280_setup(char *s) __init;
/*
@@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
}
-static int
+static int __init
qla1280_get_token(char *str)
{
char *sep;
---
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qla1280: fix section mismatch warnings
2006-05-25 17:39 [PATCH] qla1280: fix section mismatch warnings Randy.Dunlap
@ 2006-05-25 17:41 ` İsmail Dönmez
2006-05-25 21:46 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: İsmail Dönmez @ 2006-05-25 17:41 UTC (permalink / raw)
To: Randy.Dunlap, linux-kernel
Randy.Dunlap wrote On 25-05-2006 20:39:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix section mismatch warnings:
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> and 'qla1280_probe_one'
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> and 'qla1280_probe_one'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/scsi/qla1280.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Ack, fixes the warning for me. Thanks Randy!
Regards,
ismail
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qla1280: fix section mismatch warnings
2006-05-25 17:39 [PATCH] qla1280: fix section mismatch warnings Randy.Dunlap
2006-05-25 17:41 ` İsmail Dönmez
@ 2006-05-25 21:46 ` Andrew Morton
2006-05-25 22:08 ` Randy.Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2006-05-25 21:46 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: ismail, linux-scsi, james.bottomley, jes
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix section mismatch warnings:
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> and 'qla1280_probe_one'
> WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> and 'qla1280_probe_one'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/scsi/qla1280.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2617-rc5.orig/drivers/scsi/qla1280.c
> +++ linux-2617-rc5/drivers/scsi/qla1280.c
> @@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
> * QLogic Driver Support Function Prototypes.
> */
> static void qla1280_done(struct scsi_qla_host *);
> -static int qla1280_get_token(char *);
> +static int qla1280_get_token(char *) __init;
We don't normally put section tags on declarations. So I dropped this hunk
- unless you see a need for it?
> static int qla1280_setup(char *s) __init;
OK, for consistency. But let's not be consistent with inconsistent stuff ;)
> /*
> @@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
> }
>
>
> -static int
> +static int __init
> qla1280_get_token(char *str)
> {
> char *sep;
And that's not really a bugfix - it's just a save-a-bit-of-memory fix.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] qla1280: fix section mismatch warnings
2006-05-25 21:46 ` Andrew Morton
@ 2006-05-25 22:08 ` Randy.Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-05-25 22:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: ismail, linux-scsi, james.bottomley, jes
On Thu, 25 May 2006 14:46:33 -0700 Andrew Morton wrote:
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Fix section mismatch warnings:
> > WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> > .init.data: from .text between 'qla1280_get_token' (at offset 0x2a16)
> > and 'qla1280_probe_one'
> > WARNING: drivers/scsi/qla1280.o - Section mismatch: reference to
> > .init.data: from .text between 'qla1280_get_token' (at offset 0x2a3c)
> > and 'qla1280_probe_one'
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> > drivers/scsi/qla1280.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > --- linux-2617-rc5.orig/drivers/scsi/qla1280.c
> > +++ linux-2617-rc5/drivers/scsi/qla1280.c
> > @@ -456,7 +456,7 @@ static void qla1280_remove_one(struct pc
> > * QLogic Driver Support Function Prototypes.
> > */
> > static void qla1280_done(struct scsi_qla_host *);
> > -static int qla1280_get_token(char *);
> > +static int qla1280_get_token(char *) __init;
>
> We don't normally put section tags on declarations. So I dropped this hunk
> - unless you see a need for it?
>
> > static int qla1280_setup(char *s) __init;
>
> OK, for consistency. But let's not be consistent with inconsistent stuff ;)
Right. :)
> > /*
> > @@ -4234,7 +4234,7 @@ qla1280_setup(char *s)
> > }
> >
> >
> > -static int
> > +static int __init
> > qla1280_get_token(char *str)
> > {
> > char *sep;
>
> And that's not really a bugfix - it's just a save-a-bit-of-memory fix.
Yes, that's accurate.
I'll start noting severity levels...
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-05-25 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-25 17:39 [PATCH] qla1280: fix section mismatch warnings Randy.Dunlap
2006-05-25 17:41 ` İsmail Dönmez
2006-05-25 21:46 ` Andrew Morton
2006-05-25 22:08 ` Randy.Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.