From: Patrick McHardy <kaber@trash.net>
To: Philip Craig <philipc@snapgear.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 1/4] TCPMSS: dont drop packets
Date: Fri, 26 May 2006 16:40:38 +0200 [thread overview]
Message-ID: <44771366.90204@trash.net> (raw)
In-Reply-To: <4474EF6F.8060102@snapgear.com>
Philip Craig wrote:
> On 05/25/2006 02:16 AM, Patrick McHardy wrote:
>
>>philipc@snapgear.com wrote:
>>
>>>The test case that caused problems was syn packet containing data.
>>
>>That seems to be an invalid testcase.
>
>
> I'm not sure if any stacks send or accept this in practice, but it is
> allowed by RFC 793, see second paragraph in section 3.4. Please correct
> me if this is no longer valid.
No, you seem to be right. So I guess the entire check should be removed.
I'll look into this when finishing my other TCPMSS pathces.
next prev parent reply other threads:[~2006-05-26 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 4:04 [PATCH 0/4] netfilter patches for consideration philipc
2006-05-24 4:04 ` [PATCH 1/4] TCPMSS: dont drop packets philipc
2006-05-24 16:16 ` Patrick McHardy
2006-05-24 23:42 ` Philip Craig
2006-05-26 14:40 ` Patrick McHardy [this message]
2006-05-24 4:04 ` [PATCH 2/4] TCPMSS: clamp to input interface MTU too philipc
2006-05-24 16:18 ` Patrick McHardy
2006-05-24 4:04 ` [PATCH 3/4] log dropped ICMP redirects philipc
2006-05-24 16:26 ` Patrick McHardy
2006-05-25 2:34 ` Philip Craig
2006-05-26 14:49 ` Patrick McHardy
2006-05-24 4:04 ` [PATCH 4/4] drop ftp bounce attacks philipc
2006-05-24 16:31 ` Patrick McHardy
2006-05-25 2:55 ` Philip Craig
2006-05-26 14:51 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44771366.90204@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.