All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul.moore@hp.com>
To: James Morris <jmorris@namei.org>
Cc: netdev@vger.kernel.org, linux-security-module@vger.kernel.org,
	selinux@tycho.nsa.gov, James Morris <jmorris@redhat.com>,
	Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [RFC 0/4] NetLabel
Date: Fri, 26 May 2006 12:34:33 -0400	[thread overview]
Message-ID: <44772E19.5030907@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0605261156030.3103@d.namei>

James Morris wrote:
> On Fri, 26 May 2006, Paul Moore wrote:
>>>- Why does this module have a version number?
>>>
>>>+       printk(KERN_INFO "NetLabel: Initializing (v%s %s)\n",
>>>+              NETLBL_VER_STR, NETLBL_VER_DATE);
>>>
>>
>>The version number is there primarily to help signal possible
>>differences in the NetLabel netlink protocol.
> 
> How will this ever help anything?
> 
> If you change that protocol, userspace applications will break, which is 
> not acceptable.  You can add versioning at the protocol level or via 
> adding a new netlink family in the future, but existing apps cannot break 
> and you need to maintain compatibility.
> 

The NetLabel netlink protocol does have a "version" message which can be
used to get the version.  My main reason for doing this is not to signal
changes to existing messages, i.e. break backward compatability, but to
signal to user space applications that the kernel supports a newer protocol.

The printk() above is just informative, if that is your main concern I
can yank it.

-- 
paul moore
linux security @ hp

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul.moore@hp.com>
To: James Morris <jmorris@namei.org>
Cc: netdev@vger.kernel.org, linux-security-module@vger.kernel.org,
	selinux@tycho.nsa.gov, James Morris <jmorris@redhat.com>,
	Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [RFC 0/4] NetLabel
Date: Fri, 26 May 2006 12:34:33 -0400	[thread overview]
Message-ID: <44772E19.5030907@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0605261156030.3103@d.namei>

James Morris wrote:
> On Fri, 26 May 2006, Paul Moore wrote:
>>>- Why does this module have a version number?
>>>
>>>+       printk(KERN_INFO "NetLabel: Initializing (v%s %s)\n",
>>>+              NETLBL_VER_STR, NETLBL_VER_DATE);
>>>
>>
>>The version number is there primarily to help signal possible
>>differences in the NetLabel netlink protocol.
> 
> How will this ever help anything?
> 
> If you change that protocol, userspace applications will break, which is 
> not acceptable.  You can add versioning at the protocol level or via 
> adding a new netlink family in the future, but existing apps cannot break 
> and you need to maintain compatibility.
> 

The NetLabel netlink protocol does have a "version" message which can be
used to get the version.  My main reason for doing this is not to signal
changes to existing messages, i.e. break backward compatability, but to
signal to user space applications that the kernel supports a newer protocol.

The printk() above is just informative, if that is your main concern I
can yank it.

-- 
paul moore
linux security @ hp

  reply	other threads:[~2006-05-26 16:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-25 20:06 [RFC 0/4] NetLabel Paul Moore
2006-05-25 20:06 ` Paul Moore
2006-05-25 20:58 ` Stephen Hemminger
2006-05-25 21:14   ` Paul Moore
2006-05-25 21:14     ` Paul Moore
2006-05-26  0:06 ` James Morris
2006-05-26  0:06   ` James Morris
2006-05-26 15:30   ` Paul Moore
2006-05-26 15:30     ` Paul Moore
2006-05-26 16:02     ` James Morris
2006-05-26 16:02       ` James Morris
2006-05-26 16:34       ` Paul Moore [this message]
2006-05-26 16:34         ` Paul Moore
2006-05-26 18:56         ` James Morris
2006-05-26 18:56           ` James Morris
2006-05-26 16:09     ` Mikel L. Matthews
2006-05-26 16:09       ` Mikel L. Matthews
2006-05-26 16:15       ` Paul Moore
2006-05-26 16:15         ` Paul Moore
2006-05-26 16:20         ` Mikel L. Matthews
2006-05-26 16:20           ` Mikel L. Matthews

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44772E19.5030907@hp.com \
    --to=paul.moore@hp.com \
    --cc=jmorris@namei.org \
    --cc=jmorris@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.