[Bridge] setportprio problem with bridge-utils 1.0.6

[Bridge] setportprio problem with bridge-utils 1.0.6

[Samuel Díaz García]

I'm having a problem with brctl when I want to set prio in a bridge port.

When I execute:

brctl setbridgeprio br0 eth1 10

(for example)

I can see how that value (10) is asigned to the port cost.

Is this a known issue with this version?

I detected this with FC5 bridge-utils package and with dd-wrt bridge-utils.

Any help about this?

-- 
    Samuel Díaz García
     Director Gerente
ArcosCom Wireless, S.L.L.

CIF: B11828068
c/ Romero Gago, 19
Arcos de la Frontera
11630 - Cadiz

http://www.arcoscom.com

mailto:samueldg@arcoscom.com
msn: samueldg@arcoscom.com

Móvil: 651 93 72 48
Tlfn.: 956 70 13 15
Fax:   956 70 34 83

Re: [Bridge] setportprio problem with bridge-utils 1.0.6

[Stephen Hemminger]

On Tue, 30 May 2006 23:46:25 +0200
Samuel Díaz García <samueldg@arcoscom.com> wrote:

> I'm having a problem with brctl when I want to set prio in a bridge port.
> 
> When I execute:
> 
> brctl setbridgeprio br0 eth1 10
> 
> (for example)

All it ends up doing is writing a 10 to /sys/class/net/br0/bridge/port_cost

The problem (or feature) is that the bridge will autodetect
the port cost based on the link speed when the bridge or port
is started up. So you need to change the port cost after the
bridge is already running to cause any effect.

> 
> I can see how that value (10) is asigned to the port cost.
> 
> Is this a known issue with this version?
> 
> I detected this with FC5 bridge-utils package and with dd-wrt bridge-utils.
> 
> Any help about this?
> 

Re: [Bridge] setportprio problem with bridge-utils 1.0.6

[Samuel Díaz García]

Thanks Stepen, again, and sorry for my english, perhaps is this the 
problem too: my english.

I want to set port prio, to values as 1, 2, 3, 4, etc.. (little values), 
my problem is that when I run:

brctl setportprio br0 eth1 3

That "3" goes to "port cost" no goes into "port priority", that is my 
problem.

Any help more?

Stephen Hemminger escribió:
> On Wed, 31 May 2006 13:01:56 +0200
> Samuel Díaz García <samueldg@arcoscom.com> wrote:
> 
>> Thanks Stephen.
>>
>> The problem is I want to set the port prio, not the cost. The cost is 
>> working (at least brctl showstp br0 shows fine, gg).
>>
>> Would work with ..../port_prio too?
> 
> You know that port_prio is limited to 6 bits now that bridge can have up
> to 1024 ports.
> 

-- 
    Samuel Díaz García
     Director Gerente
ArcosCom Wireless, S.L.L.

CIF: B11828068
c/ Romero Gago, 19
Arcos de la Frontera
11630 - Cadiz

http://www.arcoscom.com

mailto:samueldg@arcoscom.com
msn: samueldg@arcoscom.com

Móvil: 651 93 72 48
Tlfn.: 956 70 13 15
Fax:   956 70 34 83

[Bridge] [PATCH] Fix bug where changing port priority changed path cost instead.

[Stephen Hemminger]

Just applied this to the bridge git repository.

---

 ChangeLog         |    4 ++++
 brctl/brctl_cmd.c |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

32a43e993241ff53f3333c4533d135c4f6cead73
diff --git a/ChangeLog b/ChangeLog
index e31da93..435d2f5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2006-05-31  Stephen Hemminger  <shemminger@zqx3.pdx.osdl.net>
+
+	* Fixed bug where setting port priority set path cost instead
+
 2006-01-31  Stephen Hemminger  <shemminger@osdl.org>
 
 	* Released bridge-utils 1.1
diff --git a/brctl/brctl_cmd.c b/brctl/brctl_cmd.c
index 6d0785e..67aaad4 100644
--- a/brctl/brctl_cmd.c
+++ b/brctl/brctl_cmd.c
@@ -267,7 +267,7 @@ static int br_cmd_setportprio(int argc, 
 		return 1;
 	}
 
-	err = br_set_path_cost(argv[1], argv[2], cost);
+	err = br_set_port_priority(argv[1], argv[2], cost);
 	if (err)
 		fprintf(stderr, "set port priority failed: %s\n",
 			strerror(errno));
-- 
1.2.4