[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[Hans de Goede]

Hi all,

Now that the abituguru driver is seeing some more widespread testing it
has turned out that one the first generation of Abit uGuru motherboards,
with uGuru revision 1, the autodetect bank1 sensor type code doesn't
(always) work.

Thispatch adds a module param to override the autodetect, and it adds
validity checks for the value of the 2 other autodetection override
module params. An example of howto use the new param can be found here:
http://lm-sensors.org/wiki/Configurations/Abit/AN7

It would be nice if this patch could be merged before 2.6.18, as without
it the uguru driver is useless for people with the affected motherboards.

Regards,

Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-abituguru-override-bank1detect.patch
Type: text/x-patch
Size: 2379 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060625/28b1a1bb/attachment.bin 

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect-doc.patch

[Hans de Goede]

Hi all,

Documentation update for the new bank1_types module param added by
hwmon-abituguru-override-bank1detect.patch

This patch also adds what we know about different revisions of the uGuru
and a note that the abituguru driver unfortunatly doesnot work at the
latest and greatest motherboards, which have what I think is revision 4
of the uGuru.

Regards,

Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-abituguru-override-bank1detect-doc.patch
Type: text/x-patch
Size: 3140 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060625/41c203c7/attachment-0001.bin 

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[Jean Delvare]

Hi Hans,

> Now that the abituguru driver is seeing some more widespread testing it
> has turned out that one the first generation of Abit uGuru motherboards,
> with uGuru revision 1, the autodetect bank1 sensor type code doesn't
> (always) work.
> 
> Thispatch adds a module param to override the autodetect, and it adds
> validity checks for the value of the 2 other autodetection override
> module params. An example of howto use the new param can be found here:
> http://lm-sensors.org/wiki/Configurations/Abit/AN7
> 
> It would be nice if this patch could be merged before 2.6.18, as without
> it the uguru driver is useless for people with the affected motherboards.

Fine with me, except for:

> --- linux-2.6.17-rc4-mm1.orig/drivers/hwmon/abituguru.c	2006-06-25 13:49:18.000000000 +0200
> +++ linux-2.6.17-rc4-mm1/drivers/hwmon/abituguru.c	2006-06-25 13:51:17.000000000 +0200
> @@ -142,6 +142,14 @@
>  static int force;
>  module_param(force, bool, 0);
>  MODULE_PARM_DESC(force, "Set to one to force detection.");
> +static int bank1_types[16] = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
> +	-1, -1, -1, -1 };

This "16" is actually ABIT_UGURU_MAX_BANK1_SENSORS, right?

> +module_param_array(bank1_types, int, NULL, 0);
> +MODULE_PARM_DESC(bank1_types, "Bank1 sensortype autodetection override:\n"
> +	"   -1 autodetect\n"
> +	"    0 volt sensor\n"
> +	"    1 temp sensor\n"
> +	"    2 not connected");

The "-1" is a detail implementation, user-space doesn't need to know
about it.

-- 
Jean Delvare

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[Jean Delvare]

Quoting myself:
> > +module_param_array(bank1_types, int, NULL, 0);
> > +MODULE_PARM_DESC(bank1_types, "Bank1 sensortype autodetection override:\n"
> > +	"   -1 autodetect\n"
> > +	"    0 volt sensor\n"
> > +	"    1 temp sensor\n"
> > +	"    2 not connected");
> 
> The "-1" is a detail implementation, user-space doesn't need to know
> about it.

I take that back, the user might need to pass -1 if he/she wants to
override some sensor types but leave the others in autodetection mode.

-- 
Jean Delvare

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[Hans de Goede]

Jean Delvare wrote:
> Hi Hans,
> 
>> Now that the abituguru driver is seeing some more widespread testing it
>> has turned out that one the first generation of Abit uGuru motherboards,
>> with uGuru revision 1, the autodetect bank1 sensor type code doesn't
>> (always) work.
>>
>> Thispatch adds a module param to override the autodetect, and it adds
>> validity checks for the value of the 2 other autodetection override
>> module params. An example of howto use the new param can be found here:
>> http://lm-sensors.org/wiki/Configurations/Abit/AN7
>>
>> It would be nice if this patch could be merged before 2.6.18, as without
>> it the uguru driver is useless for people with the affected motherboards.
> 
> Fine with me, except for:
> 
>> --- linux-2.6.17-rc4-mm1.orig/drivers/hwmon/abituguru.c	2006-06-25 13:49:18.000000000 +0200
>> +++ linux-2.6.17-rc4-mm1/drivers/hwmon/abituguru.c	2006-06-25 13:51:17.000000000 +0200
>> @@ -142,6 +142,14 @@
>>  static int force;
>>  module_param(force, bool, 0);
>>  MODULE_PARM_DESC(force, "Set to one to force detection.");
>> +static int bank1_types[16] = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
>> +	-1, -1, -1, -1 };
> 
> This "16" is actually ABIT_UGURU_MAX_BANK1_SENSORS, right?
> 

You're right.

I've attached a new version of the patch with this fixed.

Regards,

Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-abituguru-override-bank1detect.patch
Type: text/x-patch
Size: 2405 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060627/aa6dc1f2/attachment.bin 

[lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch

[Jean Delvare]

Hi Hans,

> You're right.
> 
> I've attached a new version of the patch with this fixed.

Applied, thanks.

-- 
Jean Delvare