ppc32 with CONFIG_KEXEC broken

ppc32 with CONFIG_KEXEC broken

[Troy Benjegerdes]

various things like 'reserve_crashkernel' are referenced, but only
exist in arch/powerpc/kernel/machine_kexec_64.c.

( This is using the mercurial repository from
http://www.kernel.org/hg/linux-2.6/, which I believe tracks git )

Re: ppc32 with CONFIG_KEXEC broken

[Vivek Goyal]

On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
> various things like 'reserve_crashkernel' are referenced, but only
> exist in arch/powerpc/kernel/machine_kexec_64.c.
> 

I think for ppc32 the framework is present for kexec/kdump but nobody 
is actively testing/maintaining it as of today.

Thanks
Vivek

Re: ppc32 with CONFIG_KEXEC broken

[Troy Benjegerdes]

On Mon, Jun 26, 2006 at 09:58:01AM -0400, Vivek Goyal wrote:
> On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
> > various things like 'reserve_crashkernel' are referenced, but only
> > exist in arch/powerpc/kernel/machine_kexec_64.c.
> > 
> 
> I think for ppc32 the framework is present for kexec/kdump but nobody 
> is actively testing/maintaining it as of today.

Even if it's not actively being tested, introducing changes for ppc64 that
break compiles on ppc32 is going to make people unhappy.

Re: ppc32 with CONFIG_KEXEC broken

[Josh Boyer]

On 6/26/06, Troy Benjegerdes <hozer@hozed.org> wrote:
> various things like 'reserve_crashkernel' are referenced, but only
> exist in arch/powerpc/kernel/machine_kexec_64.c.

Can you send a patch that prevents people from turning KEXEC on when
using that arch?  The arch/ppc stuff is in a state of limbo at the
moment until it all gets migrated to arch/powerpc.

thx,
josh

[PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC

[Haren Myneni]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

Vivek Goyal wrote:

>On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
>  
>
>>various things like 'reserve_crashkernel' are referenced, but only
>>exist in arch/powerpc/kernel/machine_kexec_64.c.
>>
>>    
>>
>
>I think for ppc32 the framework is present for kexec/kdump but nobody 
>is actively testing/maintaining it as of today.
>  
>
At present, even though kexec support is included for PPC32, I believe, 
it has been actively tested/maintained only on gamecube.

Michael, if you are OK with this patch, please send it to upstream.
Thanks
Haren

arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function 
`early_init_devtree':
: undefined reference to `reserve_crashkernel'
arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function 
`early_init_devtree':
: undefined reference to `overlaps_crashkernel'
 This patch will fix the above build errors on ppc32 with CONFIG_KEXEC.  
Both reserve_crashkernel() and overlaps_crashkernel() should be moved to 
machine_kexec.c() after the kdump support is included on ppc32.

Signed-off-by: Haren Myneni <haren@us.ibm.com>





>Thanks
>Vivek
>_______________________________________________
>fastboot mailing list
>fastboot@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/fastboot
>  
>


[-- Attachment #2: ppc32-kexec-build-fix.patch --]
[-- Type: text/x-patch, Size: 527 bytes --]

--- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig	2006-06-26 05:33:51.000000000 -0700
+++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c	2006-06-26 05:47:04.000000000 -0700
@@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct
 {
 	return 0;
 }
+
+/*
+ * FIXME: Move the following functions to machine_kexec.c after
+ * kdump support is included on ppc32.
+ */
+void __init reserve_crashkernel(void)
+{
+}
+
+int overlaps_crashkernel(unsigned long start, unsigned long size)
+{
+	return 0;
+}

[PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC

[Haren Myneni]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

Vivek Goyal wrote:

>On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
>  
>
>>various things like 'reserve_crashkernel' are referenced, but only
>>exist in arch/powerpc/kernel/machine_kexec_64.c.
>>
>>    
>>
>
>I think for ppc32 the framework is present for kexec/kdump but nobody 
>is actively testing/maintaining it as of today.
>  
>
At present, even though kexec support is included for PPC32, I believe, 
it has been actively tested/maintained only on gamecube.

Michael, if you are OK with this patch, please send it to upstream.
Thanks
Haren

arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function 
`early_init_devtree':
: undefined reference to `reserve_crashkernel'
arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function 
`early_init_devtree':
: undefined reference to `overlaps_crashkernel'
 This patch will fix the above build errors on ppc32 with CONFIG_KEXEC.  
Both reserve_crashkernel() and overlaps_crashkernel() should be moved to 
machine_kexec.c() after the kdump support is included on ppc32.

Signed-off-by: Haren Myneni <haren@us.ibm.com>





>Thanks
>Vivek
>_______________________________________________
>fastboot mailing list
>fastboot@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/fastboot
>  
>


[-- Attachment #2: ppc32-kexec-build-fix.patch --]
[-- Type: text/x-patch, Size: 527 bytes --]

--- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig	2006-06-26 05:33:51.000000000 -0700
+++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c	2006-06-26 05:47:04.000000000 -0700
@@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct
 {
 	return 0;
 }
+
+/*
+ * FIXME: Move the following functions to machine_kexec.c after
+ * kdump support is included on ppc32.
+ */
+void __init reserve_crashkernel(void)
+{
+}
+
+int overlaps_crashkernel(unsigned long start, unsigned long size)
+{
+	return 0;
+}