* ppc32 with CONFIG_KEXEC broken @ 2006-06-26 6:31 Troy Benjegerdes 2006-06-26 13:58 ` Vivek Goyal 2006-06-26 17:01 ` ppc32 with CONFIG_KEXEC broken Josh Boyer 0 siblings, 2 replies; 6+ messages in thread From: Troy Benjegerdes @ 2006-06-26 6:31 UTC (permalink / raw) To: linux-kernel various things like 'reserve_crashkernel' are referenced, but only exist in arch/powerpc/kernel/machine_kexec_64.c. ( This is using the mercurial repository from http://www.kernel.org/hg/linux-2.6/, which I believe tracks git ) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc32 with CONFIG_KEXEC broken 2006-06-26 6:31 ppc32 with CONFIG_KEXEC broken Troy Benjegerdes @ 2006-06-26 13:58 ` Vivek Goyal 2006-06-26 17:01 ` Troy Benjegerdes 2006-06-26 19:14 ` Haren Myneni 2006-06-26 17:01 ` ppc32 with CONFIG_KEXEC broken Josh Boyer 1 sibling, 2 replies; 6+ messages in thread From: Vivek Goyal @ 2006-06-26 13:58 UTC (permalink / raw) To: Troy Benjegerdes; +Cc: linux-kernel, Fastboot mailing list, Haren Myneni On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote: > various things like 'reserve_crashkernel' are referenced, but only > exist in arch/powerpc/kernel/machine_kexec_64.c. > I think for ppc32 the framework is present for kexec/kdump but nobody is actively testing/maintaining it as of today. Thanks Vivek ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc32 with CONFIG_KEXEC broken 2006-06-26 13:58 ` Vivek Goyal @ 2006-06-26 17:01 ` Troy Benjegerdes 2006-06-26 19:14 ` Haren Myneni 1 sibling, 0 replies; 6+ messages in thread From: Troy Benjegerdes @ 2006-06-26 17:01 UTC (permalink / raw) To: Vivek Goyal; +Cc: linux-kernel, Fastboot mailing list, Haren Myneni On Mon, Jun 26, 2006 at 09:58:01AM -0400, Vivek Goyal wrote: > On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote: > > various things like 'reserve_crashkernel' are referenced, but only > > exist in arch/powerpc/kernel/machine_kexec_64.c. > > > > I think for ppc32 the framework is present for kexec/kdump but nobody > is actively testing/maintaining it as of today. Even if it's not actively being tested, introducing changes for ppc64 that break compiles on ppc32 is going to make people unhappy. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC 2006-06-26 13:58 ` Vivek Goyal @ 2006-06-26 19:14 ` Haren Myneni 2006-06-26 19:14 ` Haren Myneni 1 sibling, 0 replies; 6+ messages in thread From: Haren Myneni @ 2006-06-26 19:14 UTC (permalink / raw) To: vgoyal Cc: linuxppc-dev, Fastboot mailing list, linux-kernel, Troy Benjegerdes, ellerman [-- Attachment #1: Type: text/plain, Size: 1269 bytes --] Vivek Goyal wrote: >On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote: > > >>various things like 'reserve_crashkernel' are referenced, but only >>exist in arch/powerpc/kernel/machine_kexec_64.c. >> >> >> > >I think for ppc32 the framework is present for kexec/kdump but nobody >is actively testing/maintaining it as of today. > > At present, even though kexec support is included for PPC32, I believe, it has been actively tested/maintained only on gamecube. Michael, if you are OK with this patch, please send it to upstream. Thanks Haren arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function `early_init_devtree': : undefined reference to `reserve_crashkernel' arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function `early_init_devtree': : undefined reference to `overlaps_crashkernel' This patch will fix the above build errors on ppc32 with CONFIG_KEXEC. Both reserve_crashkernel() and overlaps_crashkernel() should be moved to machine_kexec.c() after the kdump support is included on ppc32. Signed-off-by: Haren Myneni <haren@us.ibm.com> >Thanks >Vivek >_______________________________________________ >fastboot mailing list >fastboot@lists.osdl.org >https://lists.osdl.org/mailman/listinfo/fastboot > > [-- Attachment #2: ppc32-kexec-build-fix.patch --] [-- Type: text/x-patch, Size: 527 bytes --] --- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig 2006-06-26 05:33:51.000000000 -0700 +++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c 2006-06-26 05:47:04.000000000 -0700 @@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct { return 0; } + +/* + * FIXME: Move the following functions to machine_kexec.c after + * kdump support is included on ppc32. + */ +void __init reserve_crashkernel(void) +{ +} + +int overlaps_crashkernel(unsigned long start, unsigned long size) +{ + return 0; +} ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC @ 2006-06-26 19:14 ` Haren Myneni 0 siblings, 0 replies; 6+ messages in thread From: Haren Myneni @ 2006-06-26 19:14 UTC (permalink / raw) To: vgoyal Cc: Troy Benjegerdes, Fastboot mailing list, linux-kernel, linuxppc-dev, ellerman, Michael Ellerman [-- Attachment #1: Type: text/plain, Size: 1269 bytes --] Vivek Goyal wrote: >On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote: > > >>various things like 'reserve_crashkernel' are referenced, but only >>exist in arch/powerpc/kernel/machine_kexec_64.c. >> >> >> > >I think for ppc32 the framework is present for kexec/kdump but nobody >is actively testing/maintaining it as of today. > > At present, even though kexec support is included for PPC32, I believe, it has been actively tested/maintained only on gamecube. Michael, if you are OK with this patch, please send it to upstream. Thanks Haren arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function `early_init_devtree': : undefined reference to `reserve_crashkernel' arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function `early_init_devtree': : undefined reference to `overlaps_crashkernel' This patch will fix the above build errors on ppc32 with CONFIG_KEXEC. Both reserve_crashkernel() and overlaps_crashkernel() should be moved to machine_kexec.c() after the kdump support is included on ppc32. Signed-off-by: Haren Myneni <haren@us.ibm.com> >Thanks >Vivek >_______________________________________________ >fastboot mailing list >fastboot@lists.osdl.org >https://lists.osdl.org/mailman/listinfo/fastboot > > [-- Attachment #2: ppc32-kexec-build-fix.patch --] [-- Type: text/x-patch, Size: 527 bytes --] --- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig 2006-06-26 05:33:51.000000000 -0700 +++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c 2006-06-26 05:47:04.000000000 -0700 @@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct { return 0; } + +/* + * FIXME: Move the following functions to machine_kexec.c after + * kdump support is included on ppc32. + */ +void __init reserve_crashkernel(void) +{ +} + +int overlaps_crashkernel(unsigned long start, unsigned long size) +{ + return 0; +} ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ppc32 with CONFIG_KEXEC broken 2006-06-26 6:31 ppc32 with CONFIG_KEXEC broken Troy Benjegerdes 2006-06-26 13:58 ` Vivek Goyal @ 2006-06-26 17:01 ` Josh Boyer 1 sibling, 0 replies; 6+ messages in thread From: Josh Boyer @ 2006-06-26 17:01 UTC (permalink / raw) To: Troy Benjegerdes; +Cc: linux-kernel On 6/26/06, Troy Benjegerdes <hozer@hozed.org> wrote: > various things like 'reserve_crashkernel' are referenced, but only > exist in arch/powerpc/kernel/machine_kexec_64.c. Can you send a patch that prevents people from turning KEXEC on when using that arch? The arch/ppc stuff is in a state of limbo at the moment until it all gets migrated to arch/powerpc. thx, josh ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-06-26 19:15 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-06-26 6:31 ppc32 with CONFIG_KEXEC broken Troy Benjegerdes 2006-06-26 13:58 ` Vivek Goyal 2006-06-26 17:01 ` Troy Benjegerdes 2006-06-26 19:14 ` [PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC Haren Myneni 2006-06-26 19:14 ` Haren Myneni 2006-06-26 17:01 ` ppc32 with CONFIG_KEXEC broken Josh Boyer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.