All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
	cmm@us.ibm.com, linux-kernel@vger.kernel.org,
	ext2-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem
Date: Thu, 10 Aug 2006 16:13:33 -0400	[thread overview]
Message-ID: <44DB936D.2080909@garzik.org> (raw)
In-Reply-To: <44DB8036.5020706@us.ibm.com>

Badari Pulavarty wrote:
> Andrew Morton wrote:
>> Also, JBD is presently feeding into submit_bh() buffer_heads which 
>> span two
>> machine pages, and some device drivers spit the dummy.  It'd be better to
>> fix that once, rather than twice..    
> Andrew,
> 
> I looked at this few days ago. I am not sure how we end up having 
> multiple pages (especially,
> why we end up having buffers with bh_size > pagesize) ? Do you know why ?
> 
> Easiest fix would be to fix submit_bh() to deal with multiple vecs - 
> which is vetoed by
> Jens and I agree with him :(

Yep.  The sooner we kill buffer heads and use submit_bio(), the better :)

	Jeff




WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
	cmm@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem
Date: Thu, 10 Aug 2006 16:13:33 -0400	[thread overview]
Message-ID: <44DB936D.2080909@garzik.org> (raw)
In-Reply-To: <44DB8036.5020706@us.ibm.com>

Badari Pulavarty wrote:
> Andrew Morton wrote:
>> Also, JBD is presently feeding into submit_bh() buffer_heads which 
>> span two
>> machine pages, and some device drivers spit the dummy.  It'd be better to
>> fix that once, rather than twice..    
> Andrew,
> 
> I looked at this few days ago. I am not sure how we end up having 
> multiple pages (especially,
> why we end up having buffers with bh_size > pagesize) ? Do you know why ?
> 
> Easiest fix would be to fix submit_bh() to deal with multiple vecs - 
> which is vetoed by
> Jens and I agree with him :(

Yep.  The sooner we kill buffer heads and use submit_bio(), the better :)

	Jeff




-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2006-08-10 20:14 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10  1:17 [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem Mingming Cao
2006-08-10  6:39 ` Andrew Morton
2006-08-10  6:39   ` Andrew Morton
2006-08-10 16:41   ` Mingming Cao
2006-08-10 16:41     ` Mingming Cao
2006-08-10 16:48     ` Jörn Engel
2006-08-10 16:48       ` Jörn Engel
2006-08-10 18:18     ` Andrew Morton
2006-08-10 18:18       ` Andrew Morton
2006-08-10 20:22       ` Jeff Garzik
2006-08-10 20:22         ` Jeff Garzik
2006-08-10 20:33         ` Andrew Morton
2006-08-10 20:33           ` Andrew Morton
2006-08-10 20:52           ` Jeff Garzik
2006-08-10 17:44   ` [Ext2-devel] " Theodore Tso
2006-08-10 17:44     ` Theodore Tso
2006-08-10 18:51   ` Badari Pulavarty
2006-08-10 19:23     ` Andrew Morton
2006-08-10 19:23       ` Andrew Morton
2006-08-10 19:36       ` [Ext2-devel] " Dave Kleikamp
2006-08-10 19:36         ` Dave Kleikamp
2006-08-10 19:54         ` [Ext2-devel] " Andrew Morton
2006-08-10 19:54           ` Andrew Morton
2006-08-10 20:12       ` Jeff Garzik
2006-08-10 20:12         ` Jeff Garzik
2006-08-10 20:13     ` Jeff Garzik [this message]
2006-08-10 20:13       ` Jeff Garzik
2006-08-10 20:27       ` Andrew Morton
2006-08-10 20:27         ` Andrew Morton
2006-08-10 21:00         ` Jeff Garzik
2006-08-10 21:00           ` Jeff Garzik
2006-08-10 21:11           ` [Ext2-devel] " Alex Tomas
2006-08-10 21:11             ` Alex Tomas
2006-08-10 22:18             ` [Ext2-devel] " Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DB936D.2080909@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=cmm@us.ibm.com \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.