* odd vcpu_info accesses in xen/arch/x86/time.c
@ 2006-08-29 14:56 Jan Beulich
2006-08-30 16:27 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2006-08-29 14:56 UTC (permalink / raw)
To: xen-devel
Is there a particular reason why in several places in this file, with a vcpu pointer
at hand, the vcpu_info is accessed through
v->domain->shared_info->vcpu_info[v->vcpu_id]
rather than
v->vcpu_info
Thanks, Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: odd vcpu_info accesses in xen/arch/x86/time.c
2006-08-29 14:56 odd vcpu_info accesses in xen/arch/x86/time.c Jan Beulich
@ 2006-08-30 16:27 ` Keir Fraser
2006-08-31 8:08 ` [PATCH] " Jan Beulich
0 siblings, 1 reply; 3+ messages in thread
From: Keir Fraser @ 2006-08-30 16:27 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 29/8/06 3:56 pm, "Jan Beulich" <jbeulich@novell.com> wrote:
> Is there a particular reason why in several places in this file, with a vcpu
> pointer
> at hand, the vcpu_info is accessed through
>
> v->domain->shared_info->vcpu_info[v->vcpu_id]
>
> rather than
>
> v->vcpu_info
No. They should be fixed.
-- Keir
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Re: odd vcpu_info accesses in xen/arch/x86/time.c
2006-08-30 16:27 ` Keir Fraser
@ 2006-08-31 8:08 ` Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2006-08-31 8:08 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 30.08.06 18:27 >>>
>On 29/8/06 3:56 pm, "Jan Beulich" <jbeulich@novell.com> wrote:
>
>> Is there a particular reason why in several places in this file, with a vcpu
>> pointer
>> at hand, the vcpu_info is accessed through
>>
>> v->domain->shared_info->vcpu_info[v->vcpu_id]
>>
>> rather than
>>
>> v->vcpu_info
>
>No. They should be fixed.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Index: 2006-08-28/xen/arch/x86/time.c
===================================================================
--- 2006-08-28.orig/xen/arch/x86/time.c 2006-08-31 09:52:31.000000000 +0200
+++ 2006-08-28/xen/arch/x86/time.c 2006-08-31 09:55:54.000000000 +0200
@@ -676,7 +676,7 @@ static inline void __update_vcpu_system_
struct vcpu_time_info *u;
t = &this_cpu(cpu_time);
- u = &v->domain->shared_info->vcpu_info[v->vcpu_id].time;
+ u = &v->vcpu_info->time;
version_update_begin(&u->version);
@@ -690,7 +690,7 @@ static inline void __update_vcpu_system_
void update_vcpu_system_time(struct vcpu *v)
{
- if ( v->domain->shared_info->vcpu_info[v->vcpu_id].time.tsc_timestamp !=
+ if ( v->vcpu_info->time.tsc_timestamp !=
this_cpu(cpu_time).local_tsc_stamp )
__update_vcpu_system_time(v);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-31 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-29 14:56 odd vcpu_info accesses in xen/arch/x86/time.c Jan Beulich
2006-08-30 16:27 ` Keir Fraser
2006-08-31 8:08 ` [PATCH] " Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.