All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Peter Rosin <peda@axentia.se>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti, ds90c185
Date: Tue, 20 Mar 2018 15:52:28 +0200	[thread overview]
Message-ID: <4505095.GfTyCNF5lz@avalon> (raw)
In-Reply-To: <20180317221525.18534-2-peda@axentia.se>

Hi Peter,

Thank you for the patch.

On Sunday, 18 March 2018 00:15:23 EET Peter Rosin wrote:
> Start list of actual chips compatible with "lvds-encoder".
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../devicetree/bindings/display/bridge/lvds-transmitter.txt       | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> index fd39ad34c383..9d09190d9210 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> @@ -24,6 +24,11 @@ Required properties:
> 
>  - compatible: Must be "lvds-encoder"
> 
> +	      Known actual chips (these should still use "lvds-encoder" as a
> +	      fallback compatible) include:
> +
> +	      "ti,ds90c185"

The wording sounds a bit strange to me. How about

 - compatible: Must be one or more of the following
   - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer
   - "lvds-encoder" for a generic LVDS encoder device

   When compatible with the generic version nodes must list the
   device-specific version corresponding to the device first
   followed by the generic version.

>  Required nodes:
> 
>  This device has two video ports. Their connections are modeled using the OF

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Archit Taneja <architt@codeaurora.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Gustavo Padovan <gustavo@padovan.org>,
	Sean Paul <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185
Date: Tue, 20 Mar 2018 15:52:28 +0200	[thread overview]
Message-ID: <4505095.GfTyCNF5lz@avalon> (raw)
In-Reply-To: <20180317221525.18534-2-peda@axentia.se>

Hi Peter,

Thank you for the patch.

On Sunday, 18 March 2018 00:15:23 EET Peter Rosin wrote:
> Start list of actual chips compatible with "lvds-encoder".
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../devicetree/bindings/display/bridge/lvds-transmitter.txt       | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> index fd39ad34c383..9d09190d9210 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt
> @@ -24,6 +24,11 @@ Required properties:
> 
>  - compatible: Must be "lvds-encoder"
> 
> +	      Known actual chips (these should still use "lvds-encoder" as a
> +	      fallback compatible) include:
> +
> +	      "ti,ds90c185"

The wording sounds a bit strange to me. How about

 - compatible: Must be one or more of the following
   - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer
   - "lvds-encoder" for a generic LVDS encoder device

   When compatible with the generic version nodes must list the
   device-specific version corresponding to the device first
   followed by the generic version.

>  Required nodes:
> 
>  This device has two video ports. Their connections are modeled using the OF

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-03-20 13:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17 22:15 [RFC PATCH 0/3] allow override of bus format in bridges Peter Rosin
2018-03-17 22:15 ` [RFC PATCH 1/3] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 Peter Rosin
2018-03-20 13:52   ` Laurent Pinchart [this message]
2018-03-20 13:52     ` Laurent Pinchart
2018-03-17 22:15 ` [RFC PATCH 2/3] drm: bridge: panel: allow override of the bus format Peter Rosin
2018-03-20 13:56   ` Laurent Pinchart
2018-03-20 13:56     ` Laurent Pinchart
2018-03-25 12:01     ` Peter Rosin
2018-03-26 19:03       ` Laurent Pinchart
2018-03-26 19:03         ` Laurent Pinchart
2018-03-27  8:16         ` jacopo mondi
2018-03-27  8:16           ` jacopo mondi
2018-04-03 22:18           ` Laurent Pinchart
2018-04-03 22:18             ` Laurent Pinchart
2018-03-17 22:15 ` [RFC PATCH 3/3] drm: bridge: lvds-encoder: on request, override " Peter Rosin
2018-03-20 14:00   ` Laurent Pinchart
2018-03-20 14:00     ` Laurent Pinchart
2018-03-20 13:47 ` [RFC PATCH 0/3] allow override of bus format in bridges Laurent Pinchart
2018-03-20 13:47   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4505095.GfTyCNF5lz@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.