From: Florian Fainelli <f.fainelli@gmail.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] dsa: fix for_each_child.cocci warnings
Date: Sun, 11 Jul 2021 14:20:28 -0700 [thread overview]
Message-ID: <4512cb06-bf25-2ba4-dcc0-42ad91b2bd80@gmail.com> (raw)
In-Reply-To: <162602340362.16607.1326301834403328626.git-patchwork-notify@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf(a)kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
>
> Here is the summary with links:
> - dsa: fix for_each_child.cocci warnings
> https://git.kernel.org/netdev/net/c/84f7e0bb4809
The patch subject should have been:
net: dsa: microchip: fix for_each_child.cocci warning
(singular, not plural), yes I like to paint my bike shed blue.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: patchwork-bot+netdevbpf@kernel.org, Julia Lawall <julia.lawall@inria.fr>
Cc: alobakin@pm.me, olteanv@gmail.com, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, andrew@lunn.ch,
vivien.didelot@gmail.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kbuild-all@lists.01.org
Subject: Re: [PATCH] dsa: fix for_each_child.cocci warnings
Date: Sun, 11 Jul 2021 14:20:28 -0700 [thread overview]
Message-ID: <4512cb06-bf25-2ba4-dcc0-42ad91b2bd80@gmail.com> (raw)
In-Reply-To: <162602340362.16607.1326301834403328626.git-patchwork-notify@kernel.org>
On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
>
> Here is the summary with links:
> - dsa: fix for_each_child.cocci warnings
> https://git.kernel.org/netdev/net/c/84f7e0bb4809
The patch subject should have been:
net: dsa: microchip: fix for_each_child.cocci warning
(singular, not plural), yes I like to paint my bike shed blue.
--
Florian
next prev parent reply other threads:[~2021-07-11 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 16:12 [PATCH] dsa: fix for_each_child.cocci warnings Julia Lawall
2021-07-11 16:12 ` Julia Lawall
2021-07-11 17:10 ` patchwork-bot+netdevbpf
2021-07-11 17:10 ` patchwork-bot+netdevbpf
2021-07-11 21:20 ` Florian Fainelli [this message]
2021-07-11 21:20 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2021-07-11 14:27 drivers/net/dsa/microchip/ksz_common.c:418:3-35: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 423 kernel test robot
2021-07-11 14:27 ` [PATCH] dsa: fix for_each_child.cocci warnings kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4512cb06-bf25-2ba4-dcc0-42ad91b2bd80@gmail.com \
--to=f.fainelli@gmail.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.