[PATCH] dsa: fix for_each_child.cocci warnings

[PATCH] dsa: fix for_each_child.cocci warnings

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

From: kernel test robot <lkp@intel.com>

For_each_available_child_of_node should have of_node_put() before
return around line 423.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago

 ksz_common.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic
 				if (of_property_read_u32(port, "reg",
 							 &port_num))
 					continue;
-				if (!(dev->port_mask & BIT(port_num)))
+				if (!(dev->port_mask & BIT(port_num))) {
+					of_node_put(port);
 					return -EINVAL;
+				}
 				of_get_phy_mode(port,
 						&dev->ports[port_num].interface);
 			}

[PATCH] dsa: fix for_each_child.cocci warnings

[Julia Lawall]

From: kernel test robot <lkp@intel.com>

For_each_available_child_of_node should have of_node_put() before
return around line 423.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago

 ksz_common.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic
 				if (of_property_read_u32(port, "reg",
 							 &port_num))
 					continue;
-				if (!(dev->port_mask & BIT(port_num)))
+				if (!(dev->port_mask & BIT(port_num))) {
+					of_node_put(port);
 					return -EINVAL;
+				}
 				of_get_phy_mode(port,
 						&dev->ports[port_num].interface);
 			}

Re: [PATCH] dsa: fix for_each_child.cocci warnings

[patchwork-bot+netdevbpf]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
> From: kernel test robot <lkp@intel.com>
> 
> For_each_available_child_of_node should have of_node_put() before
> return around line 423.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> [...]

Here is the summary with links:
  - dsa: fix for_each_child.cocci warnings
    https://git.kernel.org/netdev/net/c/84f7e0bb4809

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] dsa: fix for_each_child.cocci warnings

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
> From: kernel test robot <lkp@intel.com>
> 
> For_each_available_child_of_node should have of_node_put() before
> return around line 423.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> [...]

Here is the summary with links:
  - dsa: fix for_each_child.cocci warnings
    https://git.kernel.org/netdev/net/c/84f7e0bb4809

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] dsa: fix for_each_child.cocci warnings

[Florian Fainelli]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]



On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf(a)kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (refs/heads/master):
> 
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
> 
> Here is the summary with links:
>    - dsa: fix for_each_child.cocci warnings
>      https://git.kernel.org/netdev/net/c/84f7e0bb4809

The patch subject should have been:

net: dsa: microchip: fix for_each_child.cocci warning

(singular, not plural), yes I like to paint my bike shed blue.
--
Florian

Re: [PATCH] dsa: fix for_each_child.cocci warnings

[Florian Fainelli]

On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (refs/heads/master):
> 
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
> 
> Here is the summary with links:
>    - dsa: fix for_each_child.cocci warnings
>      https://git.kernel.org/netdev/net/c/84f7e0bb4809

The patch subject should have been:

net: dsa: microchip: fix for_each_child.cocci warning

(singular, not plural), yes I like to paint my bike shed blue.
--
Florian

drivers/net/dsa/microchip/ksz_common.c:418:3-35: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 423.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Alexander Lobakin <alobakin@pm.me>
CC: Vladimir Oltean <olteanv@gmail.com>
CC: Florian Fainelli <f.fainelli@gmail.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
date:   4 months ago
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/net/dsa/microchip/ksz_common.c:418:3-35: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 423.
--
>> drivers/net/dsa/microchip/ksz_common.c:298:5-8: Unneeded variable: "ret". Return "0" on line 320

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28244 bytes --]

[PATCH] dsa: fix for_each_child.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Alexander Lobakin <alobakin@pm.me>
CC: Vladimir Oltean <olteanv@gmail.com>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Woojung Huh <woojung.huh@microchip.com>
CC: UNGLinuxDriver(a)microchip.com
CC: Andrew Lunn <andrew@lunn.ch>
CC: Vivien Didelot <vivien.didelot@gmail.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: netdev(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/net/dsa/microchip/ksz_common.c:418:3-35: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 423.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago

Please take the patch only if it's a positive warning. Thanks!

 ksz_common.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic
 				if (of_property_read_u32(port, "reg",
 							 &port_num))
 					continue;
-				if (!(dev->port_mask & BIT(port_num)))
+				if (!(dev->port_mask & BIT(port_num))) {
+					of_node_put(port);
 					return -EINVAL;
+				}
 				of_get_phy_mode(port,
 						&dev->ports[port_num].interface);
 			}