Re: Checking page_count(page) in invalidate_complete_page

[Steve Dickson <SteveD@redhat.com>]

Chuck Lever wrote:
> Andrew Morton wrote:
>> On Fri, 29 Sep 2006 17:48:23 -0400
>> Chuck Lever <chuck.lever@oracle.com> wrote:
>>
>>> Andrew Morton wrote:
>>>> buggerit, let's do this.  It'll fix NFS, yes?
>>> It looks right to me.
>>
>> s/right/less incorrect/ ;)
>>
>> Please double-check that it passes testing.
> 
> I've run this for 24 hours worth of continuous NFS testing.  I haven't 
> seen a problem with it.
Sorry for the delayed response.... life got in the way...
But for what's worth... I'm not longer seeing that readdir failure
with this patch...

Question: Maybe I missed this... but what is NFS suppose to do
when invalidate_inode_pages2() fails on non-file inodes? Noting
it with as metric as Chuck suggested is a good way to
detect  its happening, but does it make sense for NFS to keep
calling invalidate_inode_pages2() until it does not fail when
trying to flush the readdir cache?

steved.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>